Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Randy Dunlap 
On 09/16/17 11:18, Andreas Schwab wrote:
> On Sep 16 2017, Pavel Machek  wrote:
> 
>> diff --git a/Documentation/networking/switchdev.txt 
>> b/Documentation/networking/switchdev.txt
>> index 5e40e1f..6309e90 100644
>> --- a/Documentation/networking/switchdev.txt
>> +++ b/Documentation/networking/switchdev.txt
>> @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
>>    sw1p1  +  sw1p3  +  sw1p5  +  eth1
>>  +|+|+|+
>>  |||||||
>> - +--++++-+--++---+  +-+-+
>> + +--++++++---+  +-+-+
>>   | Switch driver |  |mgmt   |
>>   |(this document)|  |   driver  |
>>   |   |  |   |
>>
> 
> This is all mis-aligned.  How about replacing all the thin space
> characters by normal spaces?

Yes, there are lots of non-ASCII "spaces" in the ASCII art.  :(

-- 
~Randy

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Pavel Machek 
On Sat 2017-09-16 20:18:15, Andreas Schwab wrote:
> On Sep 16 2017, Pavel Machek  wrote:
> 
> > diff --git a/Documentation/networking/switchdev.txt 
> > b/Documentation/networking/switchdev.txt
> > index 5e40e1f..6309e90 100644
> > --- a/Documentation/networking/switchdev.txt
> > +++ b/Documentation/networking/switchdev.txt
> > @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
> >    sw1p1  +  sw1p3  +  sw1p5  +  eth1
> >  +|+|+|+
> >  |||||||
> > - +--++++-+--++---+  +-+-+
> > + +--++++++---+  +-+-+
> >   | Switch driver |  |mgmt   |
> >   |(this document)|  |   driver  |
> >   |   |  |   |
> >
> 
> This is all mis-aligned.  How about replacing all the thin space
> characters by normal spaces?

It looked perfectly ok to me, in emacs. If you see a problem, please
submit followup patch.
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Andreas Schwab 
On Sep 16 2017, Pavel Machek  wrote:

> diff --git a/Documentation/networking/switchdev.txt 
> b/Documentation/networking/switchdev.txt
> index 5e40e1f..6309e90 100644
> --- a/Documentation/networking/switchdev.txt
> +++ b/Documentation/networking/switchdev.txt
> @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
>    sw1p1  +  sw1p3  +  sw1p5  +  eth1
>  +|+|+|+
>  |||||||
> - +--++++-+--++---+  +-+-+
> + +--++++++---+  +-+-+
>   | Switch driver |  |mgmt   |
>   |(this document)|  |   driver  |
>   |   |  |   |
>

This is all mis-aligned.  How about replacing all the thin space
characters by normal spaces?

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Andrew Lunn 
On Sat, Sep 16, 2017 at 06:22:17PM +0200, Pavel Machek wrote:
> 
> Fix ascii-art.
> 
> Signed-off-by: Pavel Machek 
> 
> ---
> 
> Resent, because I did not get DaveM's address right.
> 
> diff --git a/Documentation/networking/switchdev.txt 
> b/Documentation/networking/switchdev.txt
> index 5e40e1f..6309e90 100644
> --- a/Documentation/networking/switchdev.txt
> +++ b/Documentation/networking/switchdev.txt
> @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
>  ??sw1p1??? + 
>  sw1p3  + ???sw1p5  +  eth1
>  
> +|+|+|+
>  
> |||||||
> -???+--++++-+--++---+??+-+-+
> +???+--++++++---+??+-+-+
>  
> ???|???Switch???driver???|??|mgmt?|
>  
> ???|(this???document)|??|?driver??|
>  
> ???|?|??|?|

Hi Pavel

This is not very readable. Has the patch been mangled by your email?

   Andrew

[PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Pavel Machek 

Fix ascii-art.

Signed-off-by: Pavel Machek 

---

Resent, because I did not get DaveM's address right.

diff --git a/Documentation/networking/switchdev.txt 
b/Documentation/networking/switchdev.txt
index 5e40e1f..6309e90 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
   sw1p1  +  sw1p3  +  sw1p5  +  eth1
 +|+|+|+
 |||||||
- +--++++-+--++---+  +-+-+
+ +--++++++---+  +-+-+
  | Switch driver |  |mgmt   |
  |(this document)|  |   driver  |
  |   |  |   |

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



- End forwarded message -

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature