[PATCH] Don't needlessly initialize variable to NULL in zd_chip (was: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver)

[Jesper Juhl]

On Friday 31 August 2007 00:19:53 Joe Perches wrote:
 On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote:
  Ok, I must admit I didn't check with sparse since it seemed pointless
  - we usually never cast void pointers to other pointer types,
  specifically because the C language nicely guarantees that the right
  thing will happen without the cast.  Sometimes we have to cast them to
  integer types, su sure we need the cast there.   But what on earth
  makes a zd_addr_t * so special that we have to explicitly cast a
  void * to that type?
 
 http://marc.info/?l=linux-netdevm=117113743902549w=1
 

Thank you for that link Joe.

I'm not sure I agree with the __nocast, but I respect that this is 
the maintainers choice.

But, I still think the first chunk of the patch that removes the 
initial variable initialization makes sense. 
Initializing the variable to NULL is pointless since it'll never be
used before the kmalloc() call. So here's a revised patch that just
gets rid of that little detail.



No need to initialize to NULL when variable is never used before 
it's assigned the return value of a kmalloc() call.

Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---

diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c 
b/drivers/net/wireless/zd1211rw/zd_chip.c
index c39f198..30872fe 100644
--- a/drivers/net/wireless/zd1211rw/zd_chip.c
+++ b/drivers/net/wireless/zd1211rw/zd_chip.c
@@ -106,7 +106,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, 
const zd_addr_t *addr
 {
int r;
int i;
-   zd_addr_t *a16 = (zd_addr_t *)NULL;
+   zd_addr_t *a16;
u16 *v16;
unsigned int count16;
 


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't needlessly initialize variable to NULL in zd_chip (was: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver)

[Jesper Juhl]

On 31/08/2007, Randy Dunlap [EMAIL PROTECTED] wrote:
...

 BTW:  http://marc.info/?l=linux-wirelessm=118831813500769w=2

...

Heh, thanks Randy.

All too often patches get missed since I don't happen to include the
right magic person to Cc. So I generally take a better to have one Cc
too many than miss one approach when sending patches - otherwise I
just end up resending it several times and eventually have to bother
Andrew to move it through -mm.

I see the point of people not getting things twice, but too many
patches slip through the cracks already (and not just my patches,
that's a general problem) so I'd rather inconvenience a few people
with one extra email than missing the proper maintainer by not Cc'ing
the right list.Picking the right list/set of people to Cc is hard!


(whoops, mistakenly didn't do a reply-to-all initially; sorry Randy,
now you'll get this mail twice ;)


--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please  http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html