Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

[Joe Perches]

On Mon, 2016-08-22 at 22:50 +0200, SF Markus Elfring wrote:
> > @@ -2289,6 +2299,10 @@ sub process {
> >     }
> >  
> >     if ($found_file) {
> > +   if (is_maintained_obsolete($realfile)) {
> > +   WARN("OBSOLETE",
> > +    "$realfile is marked as 'obsolete' in the 
> > MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
> > +   }
> How do you think about to avoid a double negation in such a warning message?
> 
> Would a wording like "… Only really necessary modifications please.\n"
> be more useful here?

No, probably not.

Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

[SF Markus Elfring]

> @@ -2289,6 +2299,10 @@ sub process {
>   }
>  
>   if ($found_file) {
> + if (is_maintained_obsolete($realfile)) {
> + WARN("OBSOLETE",
> +  "$realfile is marked as 'obsolete' in the 
> MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
> + }

How do you think about to avoid a double negation in such a warning message?

Would a wording like "… Only really necessary modifications please.\n"
be more useful here?

Regards,
Markus

[PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

[Joe Perches]

Use get_maintainer to check the status of individual files.
If "obsolete", suggest leaving the files alone.

Signed-off-by: Joe Perches 
---
 scripts/checkpatch.pl | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4de3cc4..df5e9d9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -704,6 +704,16 @@ sub seed_camelcase_file {
}
 }
 
+sub is_maintained_obsolete {
+   my ($filename) = @_;
+
+   return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
+
+   my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol 
--nogit --nogit-fallback $filename 2>&1`;
+
+   return $status =~ /obsolete/i;
+}
+
 my $camelcase_seeded = 0;
 sub seed_camelcase_includes {
return if ($camelcase_seeded);
@@ -2289,6 +2299,10 @@ sub process {
}
 
if ($found_file) {
+   if (is_maintained_obsolete($realfile)) {
+   WARN("OBSOLETE",
+"$realfile is marked as 'obsolete' in the 
MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
+   }
if ($realfile =~ 
m@^(?:drivers/net/|net/|drivers/staging/)@) {
$check = 1;
} else {
-- 
2.8.0.rc4.16.g56331f8