Re: [PATCH] dm9601: Return 0 from bind() on success

2007-07-02 Thread Jeff Garzik 

Peter Korsgaard wrote:

Fixup dm9601_bind() so it returns 0 on success rather than just a positive
number, as otherwise usbnet doesn't init the status handler.

Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]

---
 drivers/net/usb/dm9601.c |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)


applied


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] dm9601: Return 0 from bind() on success

2007-06-30 Thread Peter Korsgaard 

Fixup dm9601_bind() so it returns 0 on success rather than just a positive
number, as otherwise usbnet doesn't init the status handler.

Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]

---
 drivers/net/usb/dm9601.c |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

Index: linux-2.6.22-rc6/drivers/net/usb/dm9601.c
===
--- linux-2.6.22-rc6.orig/drivers/net/usb/dm9601.c
+++ linux-2.6.22-rc6/drivers/net/usb/dm9601.c
@@ -414,18 +414,16 @@
dev-mii.reg_num_mask = 0x1f;
 
/* reset */
-   ret = dm_write_reg(dev, DM_NET_CTRL, 1);
+   dm_write_reg(dev, DM_NET_CTRL, 1);
udelay(20);
 
/* read MAC */
-   ret = dm_read(dev, DM_PHY_ADDR, ETH_ALEN, dev-net-dev_addr);
-   if (ret  0) {
+   if (dm_read(dev, DM_PHY_ADDR, ETH_ALEN, dev-net-dev_addr)  0) {
printk(KERN_ERR Error reading MAC address\n);
ret = -ENODEV;
goto out;
}
 
-
/* power up phy */
dm_write_reg(dev, DM_GPR_CTRL, 1);
dm_write_reg(dev, DM_GPR_DATA, 0);

-- 
Bye, Peter Korsgaard

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html