Re: [PATCH] drivers/net: Fix various unnecessary characters after logging newlines

2018-05-30 Thread David Miller
From: Joe Perches 
Date: Mon, 28 May 2018 19:51:57 -0700

> Remove and coalesce formats when there is an unnecessary
> character after a logging newline.  These extra characters
> cause logging defects.
> 
> Miscellanea:
> 
> o Coalesce formats
> 
> Signed-off-by: Joe Perches 

Applied to net-next, thanks Joe.


[PATCH] drivers/net: Fix various unnecessary characters after logging newlines

2018-05-28 Thread Joe Perches
Remove and coalesce formats when there is an unnecessary
character after a logging newline.  These extra characters
cause logging defects.

Miscellanea:

o Coalesce formats

Signed-off-by: Joe Perches 
---
 drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +-
 drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 6 ++
 drivers/net/ethernet/qlogic/qed/qed_dev.c   | 2 +-
 drivers/net/ethernet/qlogic/qlge/qlge_main.c| 4 ++--
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
 drivers/net/wireless/intel/ipw2x00/ipw2200.c| 3 +--
 drivers/net/wireless/intersil/prism54/islpci_eth.c  | 6 +++---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c  | 4 ++--
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c  | 4 ++--
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c   | 4 ++--
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 2 +-
 11 files changed, 18 insertions(+), 21 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c 
b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index e500528ad751..8a815bb57177 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -1766,7 +1766,7 @@ static int load_firmware(struct octeon_device *oct)
 
ret = request_firmware(&fw, fw_name, &oct->pci_dev->dev);
if (ret) {
-   dev_err(&oct->pci_dev->dev, "Request firmware failed. Could not 
find file %s.\n.",
+   dev_err(&oct->pci_dev->dev, "Request firmware failed. Could not 
find file %s.\n",
fw_name);
release_firmware(fw);
return ret;
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c 
b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
index 6cec2a6a3dcc..7503aa222392 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
@@ -146,8 +146,7 @@ netxen_get_minidump_template(struct netxen_adapter *adapter)
if ((cmd.rsp.cmd == NX_RCODE_SUCCESS) && (size == cmd.rsp.arg2)) {
memcpy(adapter->mdump.md_template, addr, size);
} else {
-   dev_err(&adapter->pdev->dev, "Failed to get minidump template, "
-   "err_code : %d, requested_size : %d, actual_size : %d\n 
",
+   dev_err(&adapter->pdev->dev, "Failed to get minidump template, 
err_code : %d, requested_size : %d, actual_size : %d\n",
cmd.rsp.cmd, size, cmd.rsp.arg2);
}
pci_free_consistent(adapter->pdev, size, addr, md_template_addr);
@@ -180,8 +179,7 @@ netxen_setup_minidump(struct netxen_adapter *adapter)
if ((err == NX_RCODE_CMD_INVALID) ||
(err == NX_RCODE_CMD_NOT_IMPL)) {
dev_info(&adapter->pdev->dev,
-   "Flashed firmware version does not support 
minidump, "
-   "minimum version required is [ %u.%u.%u ].\n ",
+   "Flashed firmware version does not support 
minidump, minimum version required is [ %u.%u.%u ]\n",
NX_MD_SUPPORT_MAJOR, NX_MD_SUPPORT_MINOR,
NX_MD_SUPPORT_SUBVERSION);
}
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c 
b/drivers/net/ethernet/qlogic/qed/qed_dev.c
index 560528962658..fde20fd9942c 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -1098,7 +1098,7 @@ int qed_final_cleanup(struct qed_hwfn *p_hwfn,
}
 
DP_VERBOSE(p_hwfn, QED_MSG_IOV,
-  "Sending final cleanup for PFVF[%d] [Command %08x\n]",
+  "Sending final cleanup for PFVF[%d] [Command %08x]\n",
   id, command);
 
qed_wr(p_hwfn, p_ptt, XSDM_REG_OPERATION_GEN, command);
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c 
b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index 8293c2028002..70de062b72a1 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -2211,7 +2211,7 @@ static int ql_clean_outbound_rx_ring(struct rx_ring 
*rx_ring)
while (prod != rx_ring->cnsmr_idx) {
 
netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev,
-"cq_id = %d, prod = %d, cnsmr = %d.\n.",
+"cq_id = %d, prod = %d, cnsmr = %d\n",
 rx_ring->cq_id, prod, rx_ring->cnsmr_idx);
 
net_rsp = (struct ob_mac_iocb_rsp *)rx_ring->curr_entry;
@@ -2258,7 +2258,7 @@ static int ql_clean_inbound_rx_ring(struct rx_ring 
*rx_ring, int budget)
while (prod != rx_ring->cnsmr_idx) {
 
netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev,
-"cq_id = %d, prod = %d, cns