Re: [PATCH] e1000e: Fix CRC stripping in hardware context bug

2008-02-15 Thread Jeff Garzik

Auke Kok wrote:

CRC stripping was only correctly enabled for packet split recieves
which is used when receiving jumbo frames. Correctly enable SECRC
also for normal buffer packet receives.

Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940.

Signed-off-by: Auke Kok [EMAIL PROTECTED]
---

 drivers/net/e1000e/netdev.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


applied


--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] e1000e: Fix CRC stripping in hardware context bug

2008-02-12 Thread Auke Kok
CRC stripping was only correctly enabled for packet split recieves
which is used when receiving jumbo frames. Correctly enable SECRC
also for normal buffer packet receives.

Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940.

Signed-off-by: Auke Kok [EMAIL PROTECTED]
---

 drivers/net/e1000e/netdev.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index b9b0d32..ea4ecc3 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -1690,6 +1690,9 @@ static void e1000_setup_rctl(struct e1000_adapter 
*adapter)
else
rctl |= E1000_RCTL_LPE;
 
+   /* Enable hardware CRC frame stripping */
+   rctl |= E1000_RCTL_SECRC;
+
/* Setup buffer sizes */
rctl = ~E1000_RCTL_SZ_4096;
rctl |= E1000_RCTL_BSEX;
@@ -1755,9 +1758,6 @@ static void e1000_setup_rctl(struct e1000_adapter 
*adapter)
 
/* Enable Packet split descriptors */
rctl |= E1000_RCTL_DTYP_PS;
-   
-   /* Enable hardware CRC frame stripping */
-   rctl |= E1000_RCTL_SECRC;
 
psrctl |= adapter-rx_ps_bsize0 
E1000_PSRCTL_BSIZE0_SHIFT;

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] e1000e: Fix CRC stripping in hardware context bug

2008-02-12 Thread Andy Gospodarek
On Tue, Feb 12, 2008 at 03:20:24PM -0800, Auke Kok wrote:
 CRC stripping was only correctly enabled for packet split recieves
 which is used when receiving jumbo frames. Correctly enable SECRC
 also for normal buffer packet receives.
 
 Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940.
 

This works well on my systems.

Signed-off-by: Andy Gospodarek [EMAIL PROTECTED]

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html