Re: [PATCH] ethtool: add support for supporting 10000baseT

[Jeff Garzik]

Auke Kok wrote:

From: Jesse Brandeburg <[EMAIL PROTECTED]>

there is missing support in ethtool for reporting 1baseT
as SUPPORTED_1baseT_Full.  The code seems to be half
implemented because the "advertising" field has the implementation.

this patch just adds it for supported reporting.

Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---

 ethtool.c |7 +++
 1 files changed, 7 insertions(+), 0 deletions(-)


applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ethtool: add support for supporting 10000baseT

[Ben Hutchings]

Kok, Auke wrote:
> Ben Hutchings wrote:
> > Auke Kok wrote:
> >> From: Jesse Brandeburg <[EMAIL PROTECTED]>
> >>
> >> there is missing support in ethtool for reporting 1baseT
> >> as SUPPORTED_1baseT_Full.  The code seems to be half
> >> implemented because the "advertising" field has the implementation.
> > 
> > I reported this lack on Sourceforge a while back:
> > 
> > Is anyone reading bugs reported there?
> 
> not really. However with plenty of new 10gig hardware going through
> here we're currently looking at ethtool support and seeing if it
> misses anything.

I think that's the only remaining issue we have with ethtool itself.
There's a wider issue of clause 45 MDIO for 10G Ethernet though.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ethtool: add support for supporting 10000baseT

[Kok, Auke]

Ben Hutchings wrote:
> Auke Kok wrote:
>> From: Jesse Brandeburg <[EMAIL PROTECTED]>
>>
>> there is missing support in ethtool for reporting 1baseT
>> as SUPPORTED_1baseT_Full.  The code seems to be half
>> implemented because the "advertising" field has the implementation.
> 
> I reported this lack on Sourceforge a while back:
> 
> Is anyone reading bugs reported there?

not really. However with plenty of new 10gig hardware going through here we're
currently looking at ethtool support and seeing if it misses anything. If you 
spot
issues, please Cc me or Jesse and netdev and of course Jeff Garzik so we can get
some patches out.

I just noticed an e1000 specific ethtool issue on there that we'll take a look 
at
as well.

Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ethtool: add support for supporting 10000baseT

[Ben Hutchings]

Auke Kok wrote:
> From: Jesse Brandeburg <[EMAIL PROTECTED]>
> 
> there is missing support in ethtool for reporting 1baseT
> as SUPPORTED_1baseT_Full.  The code seems to be half
> implemented because the "advertising" field has the implementation.

I reported this lack on Sourceforge a while back:

Is anyone reading bugs reported there?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ethtool: add support for supporting 10000baseT

[Auke Kok]

From: Jesse Brandeburg <[EMAIL PROTECTED]>

there is missing support in ethtool for reporting 1baseT
as SUPPORTED_1baseT_Full.  The code seems to be half
implemented because the "advertising" field has the implementation.

this patch just adds it for supported reporting.

Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---

 ethtool.c |7 +++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ethtool.c b/ethtool.c
index 6c7a2e3..888be57 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -725,6 +725,13 @@ static void dump_supported(struct ethtool_cmd *ep)
if (mask & SUPPORTED_2500baseX_Full) {
did1++; fprintf(stdout, "2500baseX/Full ");
}
+   if (did1 && (mask & SUPPORTED_1baseT_Full)) {
+   fprintf(stdout, "\n");
+   fprintf(stdout, "   ");
+   }
+   if (mask & SUPPORTED_1baseT_Full) {
+   did1++; fprintf(stdout, "1baseT/Full ");
+   }
fprintf(stdout, "\n");
 
fprintf(stdout, "   Supports auto-negotiation: ");
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html