Re: [PATCH] fix IGMPV3_EXP() normalization bit shift value

[David Miller]

From: David Stevens [EMAIL PROTECTED]
Date: Thu, 16 Nov 2006 18:49:30 -0700

 The IGMPV3_EXP() macro doesn't correctly shift the normalization bit, so
 time-out values are longer than they should be. Patch below for viewing
 and attached for applying.
 
 Thanks to Dirk Ooms for finding the problem in IGMPv3 - MLDv2 had a
 similar problem that was already fixed a year ago. :-(
 
 +-DLS
 
 Signed-off-by: David L Stevens [EMAIL PROTECTED]

Applied, and pushed to -stable.  Thanks David.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] fix IGMPV3_EXP() normalization bit shift value

[David Stevens]

The IGMPV3_EXP() macro doesn't correctly shift the normalization bit, so
time-out values are longer than they should be. Patch below for viewing
and attached for applying.

Thanks to Dirk Ooms for finding the problem in IGMPv3 - MLDv2 had a
similar problem that was already fixed a year ago. :-(

+-DLS

Signed-off-by: David L Stevens [EMAIL PROTECTED]

--- linux-2.6.19-rc5/include/linux/igmp.h   2006-11-16 
16:11:53.0 -0800
+++ linux-2.6.19-rc5T1/include/linux/igmp.h 2006-11-16 
16:15:46.0 -0800
@@ -191,7 +191,7 @@ struct ip_mc_list
 #define IGMPV3_MASK(value, nb) ((nb)=32 ? (value) : ((1(nb))-1)  
(value))
 #define IGMPV3_EXP(thresh, nbmant, nbexp, value) \
((value)  (thresh) ? (value) : \
-((IGMPV3_MASK(value, nbmant) | (1(nbmant+nbexp)))  \
+((IGMPV3_MASK(value, nbmant) | (1(nbmant)))  \
  (IGMPV3_MASK((value)  (nbmant), nbexp) + (nbexp
 
 #define IGMPV3_QQIC(value) IGMPV3_EXP(0x80, 4, 3, value)



mc.patch
Description: Binary data