Re: [PATCH] igb: Fix panic with NICs with 1000BASE-SX PHY

2008-02-20 Thread Jeff Garzik

Auke Kok wrote:

From: Bill Hayes [EMAIL PROTECTED]

This patch eliminates a kernel panic with the igb driver in 2.6.25-rc2 when 
running on a Intel 82575 Ethernet controller with a 1000BASE-SX PHY.  The 
panic does not happen with the 1000BASE-T PHY, only with a SX connection.  


Signed-off-by: Bill Hayes [EMAIL PROTECTED]
Signed-off-by: Andy Gospodarek [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]


applied


--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] igb: Fix panic with NICs with 1000BASE-SX PHY

2008-02-19 Thread Auke Kok
From: Bill Hayes [EMAIL PROTECTED]

This patch eliminates a kernel panic with the igb driver in 2.6.25-rc2 when 
running on a Intel 82575 Ethernet controller with a 1000BASE-SX PHY.  The 
panic does not happen with the 1000BASE-T PHY, only with a SX connection.  

Signed-off-by: Bill Hayes [EMAIL PROTECTED]
Signed-off-by: Andy Gospodarek [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---

 drivers/net/igb/igb_main.c |6 --
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index 3480cc7..6a1f230 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -816,7 +816,8 @@ void igb_reset(struct igb_adapter *adapter)
wr32(E1000_VET, ETHERNET_IEEE_VLAN_TYPE);
 
igb_reset_adaptive(adapter-hw);
-   adapter-hw.phy.ops.get_phy_info(adapter-hw);
+   if (adapter-hw.phy.ops.get_phy_info)
+   adapter-hw.phy.ops.get_phy_info(adapter-hw);
 }
 
 /**
@@ -2052,7 +2053,8 @@ static void igb_set_multi(struct net_device *netdev)
 static void igb_update_phy_info(unsigned long data)
 {
struct igb_adapter *adapter = (struct igb_adapter *) data;
-   adapter-hw.phy.ops.get_phy_info(adapter-hw);
+   if (adapter-hw.phy.ops.get_phy_info)
+   adapter-hw.phy.ops.get_phy_info(adapter-hw);
 }
 
 /**

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html