Re: [PATCH] ipv4: tcp_minisocks: use BUG_ON instead of if condition followed by BUG

[David Miller]

From: "Gustavo A. R. Silva" 
Date: Mon, 23 Oct 2017 13:10:56 -0500

> Use BUG_ON instead of if condition followed by BUG in tcp_time_wait.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva 

Applied.

[PATCH] ipv4: tcp_minisocks: use BUG_ON instead of if condition followed by BUG

[Gustavo A. R. Silva]

Use BUG_ON instead of if condition followed by BUG in tcp_time_wait.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva 
---
 net/ipv4/tcp_minisocks.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
index 2341b9f..a952357 100644
--- a/net/ipv4/tcp_minisocks.c
+++ b/net/ipv4/tcp_minisocks.c
@@ -298,8 +298,7 @@ void tcp_time_wait(struct sock *sk, int state, int timeo)
key = tp->af_specific->md5_lookup(sk, sk);
if (key) {
tcptw->tw_md5_key = kmemdup(key, sizeof(*key), 
GFP_ATOMIC);
-   if (tcptw->tw_md5_key && 
!tcp_alloc_md5sig_pool())
-   BUG();
+   BUG_ON(tcptw->tw_md5_key && 
!tcp_alloc_md5sig_pool());
}
} while (0);
 #endif
-- 
2.7.4