Re: [PATCH] mac80211: Set low initial rate in rc80211_simple

2007-07-02 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Mon, 11 Jun 2007 21:24:11 -0400

> From: Larry Finger <[EMAIL PROTECTED]>
> 
> The initial rate for STA's using rc80211_simple is set to the last
> rate in the rate table. For situations for which the signal is weak,
> the rate may be too high for authentication and association. Although
> the rc80211_simple module will adjust the speed, the response may not
> be fast enough for a successful connection. This modification sets the
> initial rate to the lowest supported value.
> 
> Signed-off-by: Larry Finger <[EMAIL PROTECTED]>
> Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
> Signed-off-by: John W. Linville <[EMAIL PROTECTED]>

Applied to net-2.6.23
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] mac80211: Set low initial rate in rc80211_simple

2007-06-11 Thread John W. Linville
From: Larry Finger <[EMAIL PROTECTED]>

The initial rate for STA's using rc80211_simple is set to the last
rate in the rate table. For situations for which the signal is weak,
the rate may be too high for authentication and association. Although
the rc80211_simple module will adjust the speed, the response may not
be fast enough for a successful connection. This modification sets the
initial rate to the lowest supported value.

Signed-off-by: Larry Finger <[EMAIL PROTECTED]>
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
---
 net/mac80211/rc80211_simple.c |   12 +++-
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/net/mac80211/rc80211_simple.c b/net/mac80211/rc80211_simple.c
index 2048cfd..5ae7fc4 100644
--- a/net/mac80211/rc80211_simple.c
+++ b/net/mac80211/rc80211_simple.c
@@ -283,14 +283,16 @@ static void rate_control_simple_rate_init(void *priv, 
void *priv_sta,
int i;
sta->txrate = 0;
mode = local->oper_hw_mode;
-   /* TODO: what is a good starting rate for STA? About middle? Maybe not
-* the lowest or the highest rate.. Could consider using RSSI from
-* previous packets? Need to have IEEE 802.1X auth succeed immediately
-* after assoc.. */
+   /* TODO: This routine should consider using RSSI from previous packets
+* as we need to have IEEE 802.1X auth succeed immediately after assoc..
+* Until that method is implemented, we will use the lowest supported 
rate
+* as a workaround, */
for (i = 0; i < mode->num_rates; i++) {
if ((sta->supp_rates & BIT(i)) &&
-   (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
+   (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED)) {
sta->txrate = i;
+   break;
+   }
}
 }
 
-- 
1.5.0.6

-- 
John W. Linville
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html