Re: [PATCH] mac80211: fix memory leak
Hello. On 2/1/2016 12:28 PM, Kalle Valo wrote: On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: Hi Sudip, On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee wrote: On error we jumped to the error label and returned the error code but we missed releasing sinfo. Signed-off-by: Sudip Mukherjee Should the From: and Signed-off-by: email addresses be the same? I think 2 years back I had a long discussion with Greg about this and since then I al submitting patches like this. A small summayg of the problem from that discussion: "we have strict DMARC check for the corporate mail server. DMARC = domain based message authentication. So the mail i sent reached all the list subscriber from a different server than our designated server, and as a result it is marked as spam in many places and I have already received a few complaints regarding that." You can add a separate "From:" line to the beginning of the commit log and git will use it then commiting the patch. I didn't find any documention but it's easy to do and should solve this. Documentation/SubmittingPatches, clause 14. MBR, Sergei
Re: [PATCH] mac80211: fix memory leak
Hi Sudip, On Mon, Feb 1, 2016 at 8:33 PM, Sudip Mukherjee wrote: > On Mon, Feb 01, 2016 at 11:28:37AM +0200, Kalle Valo wrote: >> Sudip Mukherjee writes: >> >> > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: >> >> Hi Sudip, >> >> >> >> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee >> >> wrote: >> >> > On error we jumped to the error label and returned the error code but we >> >> > missed releasing sinfo. >> >> > >> >> > Signed-off-by: Sudip Mukherjee >> >> >> >> Should the From: and Signed-off-by: email addresses be the same? >> > >> > I think 2 years back I had a long discussion with Greg about this and >> > since then I al submitting patches like this. A small summayg of the >> > problem from that discussion: >> > >> > "we have strict DMARC check for the corporate mail server. DMARC = >> > domain based message authentication. >> > So the mail i sent reached all the list subscriber from a different >> > server than our designated server, and as a result it is marked as spam >> > in many places and I have already received a few complaints regarding >> > that." >> >> You can add a separate "From:" line to the beginning of the commit log >> and git will use it then commiting the patch. I didn't find any >> documention but it's easy to do and should solve this. > > Documentation is not needed. :) > I have done that couple of time. > I will resend this patch with the extra From: line. Don't forget to include the Fixes: tag. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
Re: [PATCH] mac80211: fix memory leak
On Mon, Feb 01, 2016 at 11:28:37AM +0200, Kalle Valo wrote: > Sudip Mukherjee writes: > > > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: > >> Hi Sudip, > >> > >> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee > >> wrote: > >> > On error we jumped to the error label and returned the error code but we > >> > missed releasing sinfo. > >> > > >> > Signed-off-by: Sudip Mukherjee > >> > >> Should the From: and Signed-off-by: email addresses be the same? > > > > I think 2 years back I had a long discussion with Greg about this and > > since then I al submitting patches like this. A small summayg of the > > problem from that discussion: > > > > "we have strict DMARC check for the corporate mail server. DMARC = > > domain based message authentication. > > So the mail i sent reached all the list subscriber from a different > > server than our designated server, and as a result it is marked as spam > > in many places and I have already received a few complaints regarding > > that." > > You can add a separate "From:" line to the beginning of the commit log > and git will use it then commiting the patch. I didn't find any > documention but it's easy to do and should solve this. Documentation is not needed. :) I have done that couple of time. I will resend this patch with the extra From: line. regards sudip
Re: [PATCH] mac80211: fix memory leak
Sudip Mukherjee writes: > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: >> Hi Sudip, >> >> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee >> wrote: >> > On error we jumped to the error label and returned the error code but we >> > missed releasing sinfo. >> > >> > Signed-off-by: Sudip Mukherjee >> >> Should the From: and Signed-off-by: email addresses be the same? > > I think 2 years back I had a long discussion with Greg about this and > since then I al submitting patches like this. A small summayg of the > problem from that discussion: > > "we have strict DMARC check for the corporate mail server. DMARC = > domain based message authentication. > So the mail i sent reached all the list subscriber from a different > server than our designated server, and as a result it is marked as spam > in many places and I have already received a few complaints regarding > that." You can add a separate "From:" line to the beginning of the commit log and git will use it then commiting the patch. I didn't find any documention but it's easy to do and should solve this. -- Kalle Valo
Re: [PATCH] mac80211: fix memory leak
Hi Sudip, On Mon, Feb 1, 2016 at 3:25 PM, Sudip Mukherjee wrote: > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: >> Hi Sudip, >> >> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee >> wrote: >> > On error we jumped to the error label and returned the error code but we >> > missed releasing sinfo. >> > >> > Signed-off-by: Sudip Mukherjee >> >> Should the From: and Signed-off-by: email addresses be the same? > > I think 2 years back I had a long discussion with Greg about this and > since then I al submitting patches like this. A small summayg of the > problem from that discussion: > > "we have strict DMARC check for the corporate mail server. DMARC = > domain based message authentication. > So the mail i sent reached all the list subscriber from a different > server than our designated server, and as a result it is marked as spam > in many places and I have already received a few complaints regarding > that." Ok, fair enough then. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
Re: [PATCH] mac80211: fix memory leak
On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote:
> Hi Sudip,
>
> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee
> wrote:
> > On error we jumped to the error label and returned the error code but we
> > missed releasing sinfo.
> >
> > Signed-off-by: Sudip Mukherjee
>
> Should the From: and Signed-off-by: email addresses be the same?
I think 2 years back I had a long discussion with Greg about this and
since then I al submitting patches like this. A small summayg of the
problem from that discussion:
"we have strict DMARC check for the corporate mail server. DMARC =
domain based message authentication.
So the mail i sent reached all the list subscriber from a different
server than our designated server, and as a result it is marked as spam
in many places and I have already received a few complaints regarding
that."
>
> > ---
> > net/mac80211/sta_info.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> > index 6c198e6..36e75c4 100644
> > --- a/net/mac80211/sta_info.c
> > +++ b/net/mac80211/sta_info.c
> > @@ -561,6 +561,7 @@ static int sta_info_insert_finish(struct sta_info *sta)
> > __acquires(RCU)
> > __cleanup_single_sta(sta);
> > out_err:
> > mutex_unlock(&local->sta_mtx);
> > + kfree(sinfo);
> > rcu_read_lock();
> > return err;
> > }
>
> Looks sane to me. I must note that the bug this is fixing is only in
> the mac80211-next tree.
>
> Fixes: 5fe74014172d ("mac80211: avoid excessive stack usage in sta_info")
> Reviewed-by: Julian Calaby
thanks
regards
sudip
Re: [PATCH] mac80211: fix memory leak
Hi Sudip,
On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee
wrote:
> On error we jumped to the error label and returned the error code but we
> missed releasing sinfo.
>
> Signed-off-by: Sudip Mukherjee
Should the From: and Signed-off-by: email addresses be the same?
> ---
> net/mac80211/sta_info.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index 6c198e6..36e75c4 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -561,6 +561,7 @@ static int sta_info_insert_finish(struct sta_info *sta)
> __acquires(RCU)
> __cleanup_single_sta(sta);
> out_err:
> mutex_unlock(&local->sta_mtx);
> + kfree(sinfo);
> rcu_read_lock();
> return err;
> }
Looks sane to me. I must note that the bug this is fixing is only in
the mac80211-next tree.
Fixes: 5fe74014172d ("mac80211: avoid excessive stack usage in sta_info")
Reviewed-by: Julian Calaby
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
[PATCH] mac80211: fix memory leak
On error we jumped to the error label and returned the error code but we missed releasing sinfo. Signed-off-by: Sudip Mukherjee --- net/mac80211/sta_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 6c198e6..36e75c4 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -561,6 +561,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU) __cleanup_single_sta(sta); out_err: mutex_unlock(&local->sta_mtx); + kfree(sinfo); rcu_read_lock(); return err; } -- 1.9.1
[patch] mac80211: fix memory leak when defraging packets
From: Hong Liu <[EMAIL PROTECTED]>
We forget to free all the fragments when defraging them into one packet.
Signed-off-by: Hong Liu <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
---
net/mac80211/ieee80211.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index 873ccb0..ed86804 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -3412,8 +3412,10 @@ ieee80211_rx_h_defragment(struct ieee80211_txrx_data *rx)
return TXRX_DROP;
}
}
- while ((skb = __skb_dequeue(&entry->skb_list)))
+ while ((skb = __skb_dequeue(&entry->skb_list))) {
memcpy(skb_put(rx->skb, skb->len), skb->data, skb->len);
+ dev_kfree_skb(skb);
+ }
/* Complete frame has been reassembled - process it now */
rx->fragmented = 1;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
