Re: [PATCH] net: ethernet: wiznet: avoid format string exposure

[David Miller]

From: Kees Cook 
Date: Wed, 5 Apr 2017 14:39:35 -0700

> While unlikely, this makes sure any format strings in the device name
> can't exposure information via the resulting workqueue name.
> 
> Signed-off-by: Kees Cook 

Applied.

[PATCH] net: ethernet: wiznet: avoid format string exposure

[Kees Cook]

While unlikely, this makes sure any format strings in the device name
can't exposure information via the resulting workqueue name.

Signed-off-by: Kees Cook 
---
 drivers/net/ethernet/wiznet/w5100.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/wiznet/w5100.c 
b/drivers/net/ethernet/wiznet/w5100.c
index f90267f0519f..2bdfb39215e9 100644
--- a/drivers/net/ethernet/wiznet/w5100.c
+++ b/drivers/net/ethernet/wiznet/w5100.c
@@ -1152,7 +1152,8 @@ int w5100_probe(struct device *dev, const struct 
w5100_ops *ops,
if (err < 0)
goto err_register;
 
-   priv->xfer_wq = alloc_workqueue(netdev_name(ndev), WQ_MEM_RECLAIM, 0);
+   priv->xfer_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0,
+   netdev_name(ndev));
if (!priv->xfer_wq) {
err = -ENOMEM;
goto err_wq;
-- 
2.7.4


-- 
Kees Cook
Pixel Security