Re: [PATCH] net: phy: spi_ks8995: clean up ks8995_registers_read/write

[David Miller]

From: Vladimir Zapolskiy 
Date: Thu, 30 Jul 2015 00:44:20 +0300

> The change removes redundant sysfs binary file boundary checks,
> since this task is already done on caller side in fs/sysfs/file.c
> 
> Signed-off-by: Vladimir Zapolskiy 

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] net: phy: spi_ks8995: clean up ks8995_registers_read/write

[Vladimir Zapolskiy]

The change removes redundant sysfs binary file boundary checks,
since this task is already done on caller side in fs/sysfs/file.c

Signed-off-by: Vladimir Zapolskiy 
---
 drivers/net/phy/spi_ks8995.c | 22 --
 1 file changed, 22 deletions(-)

diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
index 4653015..f091d69 100644
--- a/drivers/net/phy/spi_ks8995.c
+++ b/drivers/net/phy/spi_ks8995.c
@@ -209,8 +209,6 @@ static int ks8995_reset(struct ks8995_switch *ks)
return ks8995_start(ks);
 }
 
-/*  */
-
 static ssize_t ks8995_registers_read(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)
 {
@@ -220,19 +218,9 @@ static ssize_t ks8995_registers_read(struct file *filp, 
struct kobject *kobj,
dev = container_of(kobj, struct device, kobj);
ks8995 = dev_get_drvdata(dev);
 
-   if (unlikely(off > ks8995->regs_attr.size))
-   return 0;
-
-   if ((off + count) > ks8995->regs_attr.size)
-   count = ks8995->regs_attr.size - off;
-
-   if (unlikely(!count))
-   return count;
-
return ks8995_read(ks8995, buf, off, count);
 }
 
-
 static ssize_t ks8995_registers_write(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)
 {
@@ -242,19 +230,9 @@ static ssize_t ks8995_registers_write(struct file *filp, 
struct kobject *kobj,
dev = container_of(kobj, struct device, kobj);
ks8995 = dev_get_drvdata(dev);
 
-   if (unlikely(off >= ks8995->regs_attr.size))
-   return -EFBIG;
-
-   if ((off + count) > ks8995->regs_attr.size)
-   count = ks8995->regs_attr.size - off;
-
-   if (unlikely(!count))
-   return count;
-
return ks8995_write(ks8995, buf, off, count);
 }
 
-
 static const struct bin_attribute ks8995_registers_attr = {
.attr = {
.name   = "registers",
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html