Re: [PATCH] net: qlcnic: Deletion of unnecessary memset

[David Miller]

From: Christophe JAILLET christophe.jail...@wanadoo.fr
Date: Mon, 13 Jul 2015 21:51:38 +0200

 There is no need to memset memory allocated with vzalloc.
 
 Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] net: qlcnic: Deletion of unnecessary memset

[Shahed Shaikh]

 -Original Message-
 From: Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr]
 Sent: Tuesday, July 14, 2015 1:22 AM
 To: Shahed Shaikh; Dept-GE Linux NIC Dev
 Cc: netdev; linux-kernel; kernel-janit...@vger.kernel.org; Christophe JAILLET
 Subject: [PATCH] net: qlcnic: Deletion of unnecessary memset
 
 There is no need to memset memory allocated with vzalloc.
 
 Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr
 ---
  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
  1 file changed, 1 deletion(-)
 
 diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
 b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
 index 2f6cc42..7dbab3c 100644
 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
 +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
 @@ -2403,7 +2403,6 @@ int qlcnic_alloc_tx_rings(struct qlcnic_adapter
 *adapter,
   qlcnic_free_tx_rings(adapter);
   return -ENOMEM;
   }
 - memset(cmd_buf_arr, 0, TX_BUFF_RINGSIZE(tx_ring));
   tx_ring-cmd_buf_arr = cmd_buf_arr;
   spin_lock_init(tx_ring-tx_clean_lock);
   }

Acked-by: Shahed Shaikh shahed.sha...@qlogic.com

Thanks,
Shahed
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] net: qlcnic: Deletion of unnecessary memset

[Christophe JAILLET]

There is no need to memset memory allocated with vzalloc.

Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c 
b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 2f6cc42..7dbab3c 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2403,7 +2403,6 @@ int qlcnic_alloc_tx_rings(struct qlcnic_adapter *adapter,
qlcnic_free_tx_rings(adapter);
return -ENOMEM;
}
-   memset(cmd_buf_arr, 0, TX_BUFF_RINGSIZE(tx_ring));
tx_ring-cmd_buf_arr = cmd_buf_arr;
spin_lock_init(tx_ring-tx_clean_lock);
}
-- 
2.1.4

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html