Re: [PATCH] prevent SSB compilation on s390 part 2
On Wednesday 01 August 2007, Heiko Carstens wrote: > On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > > From: Heiko Carstens <[EMAIL PROTECTED]> > > > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > > prevent SSB from being selected. But appearantly it looks like this > > doesn't matter at all if it gets selected from somewhere else. > > So add an explicit depends on HAS_IOMEM to the Broadcom driver to > > prevent selection on s390. > > > > Cc: "John W. Linville" <[EMAIL PROTECTED]> > > Cc: Michael Buesch <[EMAIL PROTECTED]> > > Cc: Martin Schwidefsky <[EMAIL PROTECTED]> > > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> > > --- > > drivers/net/Kconfig |1 + > > 1 files changed, 1 insertion(+) > > > > Index: linux-2.6.22/drivers/net/Kconfig > > === > > --- linux-2.6.22.orig/drivers/net/Kconfig > > +++ linux-2.6.22/drivers/net/Kconfig > > @@ -1434,6 +1434,7 @@ config APRICOT > > > > config B44 > > tristate "Broadcom 440x/47xx ethernet support" > > + depends on HAS_IOMEM > > select SSB > > select MII > > help > > By the way.. wouldn't something like depends on NET_PCI or something > similar more correct for this driver? Just wondering... > > No, B44 does not depend on PCI. It does depend on the SSB bus. (Of course the SSB PCI parts do depend on PCI) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] prevent SSB compilation on s390 part 2
On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > prevent SSB from being selected. But appearantly it looks like this > doesn't matter at all if it gets selected from somewhere else. > So add an explicit depends on HAS_IOMEM to the Broadcom driver to > prevent selection on s390. > > Cc: "John W. Linville" <[EMAIL PROTECTED]> > Cc: Michael Buesch <[EMAIL PROTECTED]> > Cc: Martin Schwidefsky <[EMAIL PROTECTED]> > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> > --- > drivers/net/Kconfig |1 + > 1 files changed, 1 insertion(+) > > Index: linux-2.6.22/drivers/net/Kconfig > === > --- linux-2.6.22.orig/drivers/net/Kconfig > +++ linux-2.6.22/drivers/net/Kconfig > @@ -1434,6 +1434,7 @@ config APRICOT > > config B44 > tristate "Broadcom 440x/47xx ethernet support" > + depends on HAS_IOMEM > select SSB > select MII > help By the way.. wouldn't something like depends on NET_PCI or something similar more correct for this driver? Just wondering... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] prevent SSB compilation on s390 part 2
On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > prevent SSB from being selected. But appearantly it looks like this > doesn't matter at all if it gets selected from somewhere else. > So add an explicit depends on HAS_IOMEM to the Broadcom driver to > prevent selection on s390. > > Cc: "John W. Linville" <[EMAIL PROTECTED]> > Cc: Michael Buesch <[EMAIL PROTECTED]> > Cc: Martin Schwidefsky <[EMAIL PROTECTED]> > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> Note to reviewers: this is only relevant to -mm and wireless-dev at the moment, AFAIK... John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] prevent SSB compilation on s390 part 2
From: Heiko Carstens <[EMAIL PROTECTED]> drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should prevent SSB from being selected. But appearantly it looks like this doesn't matter at all if it gets selected from somewhere else. So add an explicit depends on HAS_IOMEM to the Broadcom driver to prevent selection on s390. Cc: "John W. Linville" <[EMAIL PROTECTED]> Cc: Michael Buesch <[EMAIL PROTECTED]> Cc: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 + 1 files changed, 1 insertion(+) Index: linux-2.6.22/drivers/net/Kconfig === --- linux-2.6.22.orig/drivers/net/Kconfig +++ linux-2.6.22/drivers/net/Kconfig @@ -1434,6 +1434,7 @@ config APRICOT config B44 tristate "Broadcom 440x/47xx ethernet support" + depends on HAS_IOMEM select SSB select MII help - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
