[PATCH] proper comment for loopback initialization order

2007-09-27 Thread Denis V. Lunev 
Loopback device is special. It should be initialized at the very
beginning.  Initialization order has been changed by
Eric W. Biederman [EMAIL PROTECTED] and this change is non-obvious
and important enough to add proper comment.

Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]

--- ./drivers/net/loopback.c.loopcomment2007-08-26 19:30:38.0 
+0400
+++ ./drivers/net/loopback.c2007-09-27 16:08:06.0 +0400
@@ -293,4 +293,6 @@ static int __init loopback_init(void)
return register_pernet_device(loopback_net_ops);
 }
 
+/* Loopback is special. It should be initialized before any other network
+   device and network subsystem */
 fs_initcall(loopback_init);
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] proper comment for loopback initialization order

2007-09-27 Thread David Miller 
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Thu, 27 Sep 2007 16:25:27 +0400

 Subject: [PATCH] proper comment for loopback initialization order
 From: Denis V. Lunev [EMAIL PROTECTED]
 To: [EMAIL PROTECTED]
 Cc: [EMAIL PROTECTED], [EMAIL PROTECTED], netdev@vger.kernel.org,
   [EMAIL PROTECTED]
 Date: Thu, 27 Sep 2007 16:25:27 +0400
 Sender:  [EMAIL PROTECTED]
 User-Agent: Mutt/1.5.16 (2007-06-09)
 
 Loopback device is special. It should be initialized at the very
 beginning.  Initialization order has been changed by
 Eric W. Biederman [EMAIL PROTECTED] and this change is non-obvious
 and important enough to add proper comment.
 
 Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]

Applied, but I had to fix the coding style of your comment,
please do it like this in the future:

/* Loopback is special. It should be initialized before any other network
 * device and network subsystem.
 */

Thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html