Re: [PATCH] ptp: Fix resource leak in case of error

[David Miller]

From: Christophe JAILLET 
Date: Sun,  2 Oct 2016 09:04:16 +0200

> A call to 'ida_simple_remove()' is missing in the error handling path.
> 
> This as been spotted with the following coccinelle script which tries to
> detect missing 'ida_simple_remove()' call in error handling paths.
 ...
> Signed-off-by: Christophe JAILLET 

Applied.

Re: [PATCH] ptp: Fix resource leak in case of error

[Richard Cochran]

On Sun, Oct 02, 2016 at 09:04:16AM +0200, Christophe JAILLET wrote:
> A call to 'ida_simple_remove()' is missing in the error handling path.
> 
> This as been spotted with the following coccinelle script which tries to
> detect missing 'ida_simple_remove()' call in error handling paths.

Acked-by: Richard Cochran 

[PATCH] ptp: Fix resource leak in case of error

[Christophe JAILLET]

A call to 'ida_simple_remove()' is missing in the error handling path.

This as been spotted with the following coccinelle script which tries to
detect missing 'ida_simple_remove()' call in error handling paths.

///
@@
expression x;
identifier l;
@@

*   x = ida_simple_get(...);
...
if (...) {
...
}
...
if (...) {
   ...
   goto l;
}
...
*   l: ... when != ida_simple_remove(...);

Signed-off-by: Christophe JAILLET 
---
Compile-tested only
---
 drivers/ptp/ptp_clock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index 2e481b9e8ea5..86280b7e41f3 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -263,6 +263,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info 
*info,
 no_device:
mutex_destroy(>tsevq_mux);
mutex_destroy(>pincfg_mux);
+   ida_simple_remove(_clocks_map, index);
 no_slot:
kfree(ptp);
 no_memory:
-- 
2.7.4