Re: [PATCH] tcp: simpler bic default
On Tue, Sep 19, 2006 at 04:23:55PM -0700, Stephen Hemminger wrote: > Okay, build testing all the possibilities now, answer by morning.. Please boot some of them as well - I can see a kernel that really wants to load "bic" at boot time but can't find it. Bert -- http://www.PowerDNS.com Open source, database driven DNS Software http://netherlabs.nl Open and Closed source services - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp: simpler bic default
On Tue, 19 Sep 2006 16:04:41 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 19 Sep 2006 16:02:02 -0700 > > > > > > When TCP_CONG_ADVANCED is disabled, TCP_CONG_BIC should always be set > > > and be the default, but that's not what the new code is doing. > > > > > > I'm reverting Stephen's patch (again) until this is all sorted > > > out as things are still broken in various ways even with the > > > followon patch. > > > > I don't see what's wrong, this is on a kernel with the two patches: > > Look more closely: > > > After "make defconfig" > > # CONFIG_TCP_CONG_ADVANCED is not set > > CONFIG_DEFAULT_TCP_CONG="bic" > > # CONFIG_NETFILTER_XT_MATCH_TCPMSS is not set > > # CONFIG_IP_NF_TARGET_TCPMSS is not set > > # CONFIG_ISCSI_TCP is not set > > But TCP_CONG_BIC isn't enabled so it won't get built nor be > the default algorithm. When CONG_ADVANCED is off, as it is here, > TCP_CONG_BIC should be "y". That's what happens before your > changes. Okay, build testing all the possibilities now, answer by morning.. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp: simpler bic default
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 19 Sep 2006 16:02:02 -0700 > > > When TCP_CONG_ADVANCED is disabled, TCP_CONG_BIC should always be set > > and be the default, but that's not what the new code is doing. > > > > I'm reverting Stephen's patch (again) until this is all sorted > > out as things are still broken in various ways even with the > > followon patch. > > I don't see what's wrong, this is on a kernel with the two patches: Look more closely: > After "make defconfig" > # CONFIG_TCP_CONG_ADVANCED is not set > CONFIG_DEFAULT_TCP_CONG="bic" > # CONFIG_NETFILTER_XT_MATCH_TCPMSS is not set > # CONFIG_IP_NF_TARGET_TCPMSS is not set > # CONFIG_ISCSI_TCP is not set But TCP_CONG_BIC isn't enabled so it won't get built nor be the default algorithm. When CONG_ADVANCED is off, as it is here, TCP_CONG_BIC should be "y". That's what happens before your changes. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp: simpler bic default
> When TCP_CONG_ADVANCED is disabled, TCP_CONG_BIC should always be set > and be the default, but that's not what the new code is doing. > > I'm reverting Stephen's patch (again) until this is all sorted > out as things are still broken in various ways even with the > followon patch. I don't see what's wrong, this is on a kernel with the two patches: After "make defconfig" # CONFIG_TCP_CONG_ADVANCED is not set CONFIG_DEFAULT_TCP_CONG="bic" # CONFIG_NETFILTER_XT_MATCH_TCPMSS is not set # CONFIG_IP_NF_TARGET_TCPMSS is not set # CONFIG_ISCSI_TCP is not set Enable TCP_ADVANCED_CONG with make menuconfig CONFIG_TCP_CONG_ADVANCED=y # TCP congestion control CONFIG_TCP_CONG_BIC=y CONFIG_TCP_CONG_CUBIC=m CONFIG_TCP_CONG_WESTWOOD=m CONFIG_TCP_CONG_HTCP=m # CONFIG_TCP_CONG_HSTCP is not set # CONFIG_TCP_CONG_HYBLA is not set # CONFIG_TCP_CONG_VEGAS is not set # CONFIG_TCP_CONG_SCALABLE is not set # CONFIG_TCP_CONG_LP is not set # CONFIG_TCP_CONG_VENO is not set # CONFIG_DEFAULT_HTCP is not set CONFIG_DEFAULT_TCP_CONG="bic" After "make allmodconfig" CONFIG_INET_TCP_DIAG=m CONFIG_TCP_CONG_ADVANCED=y # TCP congestion control CONFIG_TCP_CONG_BIC=m CONFIG_TCP_CONG_CUBIC=m CONFIG_TCP_CONG_WESTWOOD=m CONFIG_TCP_CONG_HTCP=m CONFIG_TCP_CONG_HSTCP=m CONFIG_TCP_CONG_HYBLA=m CONFIG_TCP_CONG_VEGAS=m CONFIG_TCP_CONG_SCALABLE=m CONFIG_TCP_CONG_LP=m CONFIG_TCP_CONG_VENO=m # CONFIG_DEFAULT_HTCP is not set CONFIG_DEFAULT_TCP_CONG="reno" After "make allyesconfig" CONFIG_INET_TCP_DIAG=y CONFIG_TCP_CONG_ADVANCED=y # TCP congestion control CONFIG_TCP_CONG_BIC=y CONFIG_TCP_CONG_CUBIC=y CONFIG_TCP_CONG_WESTWOOD=y CONFIG_TCP_CONG_HTCP=y CONFIG_TCP_CONG_HSTCP=y CONFIG_TCP_CONG_HYBLA=y CONFIG_TCP_CONG_VEGAS=y CONFIG_TCP_CONG_SCALABLE=y CONFIG_TCP_CONG_LP=y CONFIG_TCP_CONG_VENO=y # CONFIG_DEFAULT_HTCP is not set CONFIG_DEFAULT_TCP_CONG="bic" - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp: simpler bic default
From: bert hubert <[EMAIL PROTECTED]> Date: Tue, 19 Sep 2006 23:43:05 +0200 > On Tue, Sep 19, 2006 at 02:32:09PM -0700, Stephen Hemminger wrote: > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > # CONFIG_TCP_CONG_ADVANCED is not set > # CONFIG_DEFAULT_BIC is not set > # CONFIG_DEFAULT_CUBIC is not set > # CONFIG_DEFAULT_HTCP is not set > # CONFIG_DEFAULT_VEGAS is not set > # CONFIG_DEFAULT_WESTWOOD is not set > # CONFIG_DEFAULT_RENO is not set > CONFIG_DEFAULT_TCP_CONG="bic" > > There is no "bic" in the kernel now - will this do the right thing? This is wrong. When TCP_CONG_ADVANCED is disabled, TCP_CONG_BIC should always be set and be the default, but that's not what the new code is doing. I'm reverting Stephen's patch (again) until this is all sorted out as things are still broken in various ways even with the followon patch. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp: simpler bic default
On Tue, Sep 19, 2006 at 02:32:09PM -0700, Stephen Hemminger wrote: > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> # CONFIG_TCP_CONG_ADVANCED is not set # CONFIG_DEFAULT_BIC is not set # CONFIG_DEFAULT_CUBIC is not set # CONFIG_DEFAULT_HTCP is not set # CONFIG_DEFAULT_VEGAS is not set # CONFIG_DEFAULT_WESTWOOD is not set # CONFIG_DEFAULT_RENO is not set CONFIG_DEFAULT_TCP_CONG="bic" There is no "bic" in the kernel now - will this do the right thing? -- http://www.PowerDNS.com Open source, database driven DNS Software http://netherlabs.nl Open and Closed source services - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] tcp: simpler bic default
New tcp default config means we can eliminate the hack that was used previous Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.19.orig/net/ipv4/Kconfig2006-09-19 14:27:58.0 -0700 +++ net-2.6.19/net/ipv4/Kconfig 2006-09-19 14:28:17.0 -0700 @@ -602,10 +602,6 @@ endmenu -config DEFAULT_BIC - depends on !TCP_CONG_ADVANCED - default y - config DEFAULT_TCP_CONG string default "bic" if DEFAULT_BIC @@ -614,6 +610,7 @@ default "vegas" if DEFAULT_VEGAS default "westwood" if DEFAULT_WESTWOOD default "reno" if DEFAULT_RENO + default "bic" source "net/ipv4/ipvs/Kconfig" - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
