Re: [PATCH] wan/sdla section fixes
"Randy.Dunlap" <[EMAIL PROTECTED]> writes: >> > static const char* version = "SDLA driver v0.30, 12 Sep 1996, >> > [EMAIL PROTECTED]"; >> >> 1996 doesn't look encouraging but it may be misleading. > > Yep. You could ignore it :) or rm drivers/net/wan/slda* :) I don't know, maybe Mike will say something? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] wan/sdla section fixes
On Mon, 12 Jun 2006 19:50:22 +0200 Krzysztof Halasa wrote: > Hi, > > "Randy.Dunlap" <[EMAIL PROTECTED]> writes: > > > Priority: tossup. > > netdev->set_config can be called at any time, so these references > > to __initdata would be a real problem. > > However, problem has not been observed AFAIK. > > > > Fix section mismatch warnings: > > WARNING: drivers/net/wan/sdla.o - Section mismatch: reference to > > .init.data: from .text between 'sdla_set_config' (at offset 0x1b8e) and > > 'sdla_stats' > > WARNING: drivers/net/wan/sdla.o - Section mismatch: reference to > > .init.data: from .text between 'sdla_set_config' (at offset 0x1e76) and > > 'sdla_stats' > > Is sdla.c still in use? I remember someone mentioned that Sangoma > drivers are now outside the kernel but I don't know how do they > relate to sdla.c and friend(s). No idea. > > static const char* version = "SDLA driver v0.30, 12 Sep 1996, > > [EMAIL PROTECTED]"; > > 1996 doesn't look encouraging but it may be misleading. Yep. You could ignore it :) or rm drivers/net/wan/slda* :) --- ~Randy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] wan/sdla section fixes
Hi, "Randy.Dunlap" <[EMAIL PROTECTED]> writes: > Priority: tossup. > netdev->set_config can be called at any time, so these references > to __initdata would be a real problem. > However, problem has not been observed AFAIK. > > Fix section mismatch warnings: > WARNING: drivers/net/wan/sdla.o - Section mismatch: reference to .init.data: > from .text between 'sdla_set_config' (at offset 0x1b8e) and 'sdla_stats' > WARNING: drivers/net/wan/sdla.o - Section mismatch: reference to .init.data: > from .text between 'sdla_set_config' (at offset 0x1e76) and 'sdla_stats' Is sdla.c still in use? I remember someone mentioned that Sangoma drivers are now outside the kernel but I don't know how do they relate to sdla.c and friend(s). > static const char* version = "SDLA driver v0.30, 12 Sep 1996, > [EMAIL PROTECTED]"; 1996 doesn't look encouraging but it may be misleading. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] wan/sdla section fixes
From: Randy Dunlap <[EMAIL PROTECTED]>
Priority: tossup.
netdev->set_config can be called at any time, so these references
to __initdata would be a real problem.
However, problem has not been observed AFAIK.
Fix section mismatch warnings:
WARNING: drivers/net/wan/sdla.o - Section mismatch: reference to .init.data:
from .text between 'sdla_set_config' (at offset 0x1b8e) and 'sdla_stats'
WARNING: drivers/net/wan/sdla.o - Section mismatch: reference to .init.data:
from .text between 'sdla_set_config' (at offset 0x1e76) and 'sdla_stats'
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
drivers/net/wan/sdla.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2617-rc6.orig/drivers/net/wan/sdla.c
+++ linux-2617-rc6/drivers/net/wan/sdla.c
@@ -60,9 +60,9 @@
static const char* version = "SDLA driver v0.30, 12 Sep 1996, [EMAIL
PROTECTED]";
-static unsigned int valid_port[] __initdata = { 0x250, 0x270, 0x280, 0x300,
0x350, 0x360, 0x380, 0x390};
+static unsigned int valid_port[] = { 0x250, 0x270, 0x280, 0x300, 0x350, 0x360,
0x380, 0x390};
-static unsigned int valid_mem[] __initdata = {
+static unsigned int valid_mem[] = {
0xA, 0xA2000, 0xA4000, 0xA6000,
0xA8000, 0xAA000, 0xAC000, 0xAE000,
0xB, 0xB2000, 0xB4000, 0xB6000,
0xB8000, 0xBA000, 0xBC000, 0xBE000,
0xC, 0xC2000, 0xC4000, 0xC6000,
0xC8000, 0xCA000, 0xCC000, 0xCE000,
---
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
