Re: [PATCH] wireless: zd1211rw: remove redundant assignment of pointer 'q'
On Wed, Jan 31, 2018 at 02:58:57PM +0200, Andy Shevchenko wrote: > On Tue, Jan 30, 2018 at 8:25 PM, Colin King wrote: > > From: Colin Ian King > > > > Pointer q is initialized and then almost immediately afterwards being > > re-assigned the same value. Remove the second redundant assignment. > > > > Don't you see strange that in the same context of the patch two users > of q are present? > > How did you test this? > The patch is obviously correct, I don't understand the question. regards, dan carpenter
Re: [PATCH] wireless: zd1211rw: remove redundant assignment of pointer 'q'
On Tue, Jan 30, 2018 at 8:25 PM, Colin King wrote: > From: Colin Ian King > > Pointer q is initialized and then almost immediately afterwards being > re-assigned the same value. Remove the second redundant assignment. > Don't you see strange that in the same context of the patch two users of q are present? How did you test this? > Cleans up clang warning: > drivers/net/wireless/zydas/zd1211rw/zd_mac.c:503:23: warning: Value > stored to 'q' during its initialization is never read > - q = &mac->ack_wait_queue; > spin_lock_irqsave(&q->lock, flags); > > skb_queue_walk(q, skb) { -- With Best Regards, Andy Shevchenko
[PATCH] wireless: zd1211rw: remove redundant assignment of pointer 'q'
From: Colin Ian King Pointer q is initialized and then almost immediately afterwards being re-assigned the same value. Remove the second redundant assignment. Cleans up clang warning: drivers/net/wireless/zydas/zd1211rw/zd_mac.c:503:23: warning: Value stored to 'q' during its initialization is never read Signed-off-by: Colin Ian King --- drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c index b785742bfd9e..b01b44a5d16e 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c @@ -509,7 +509,6 @@ void zd_mac_tx_failed(struct urb *urb) int found = 0; int i, position = 0; - q = &mac->ack_wait_queue; spin_lock_irqsave(&q->lock, flags); skb_queue_walk(q, skb) { -- 2.15.1