Re: [PATCH -next] qed: Remove useless set memory to zero use memset()

2016-10-18 Thread Sergei Shtylyov 

On 10/18/2016 06:54 PM, Wei Yongjun wrote:


From: Wei Yongjun 

The memory return by kzalloc() has already be set to zero, so


   Returned?


remove useless memset(0).

Signed-off-by: Wei Yongjun 

[...]

MBR, Sergei

[PATCH -next] qed: Remove useless set memory to zero use memset()

2016-10-18 Thread Wei Yongjun 
From: Wei Yongjun 

The memory return by kzalloc() has already be set to zero, so
remove useless memset(0).

Signed-off-by: Wei Yongjun 
---
 drivers/net/ethernet/qlogic/qed/qed_roce.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_roce.c 
b/drivers/net/ethernet/qlogic/qed/qed_roce.c
index f3a825a..6a353ff 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_roce.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_roce.c
@@ -2658,7 +2658,6 @@ static int qed_roce_ll2_start(struct qed_dev *cdev,
DP_ERR(cdev, "qed roce ll2 start: failed memory allocation\n");
return -ENOMEM;
}
-   memset(roce_ll2, 0, sizeof(*roce_ll2));
roce_ll2->handle = QED_LL2_UNUSED_HANDLE;
roce_ll2->cbs = params->cbs;
roce_ll2->cb_cookie = params->cb_cookie;