Re: [PATCH -next 1/3] net: add inet_sk_transparent() helper

[Eric Dumazet]

On Mon, 2015-12-21 at 21:29 +0100, Florian Westphal wrote:
> Avoids cluttering tcp_v4_send_reset when followup patch extends
> it to deal with timewait sockets.
> 
> Suggested-by: Eric Dumazet 
> Signed-off-by: Florian Westphal 
> ---

Acked-by: Eric Dumazet 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next 1/3] net: add inet_sk_transparent() helper

[Hannes Frederic Sowa]

On 21.12.2015 21:29, Florian Westphal wrote:
> Avoids cluttering tcp_v4_send_reset when followup patch extends
> it to deal with timewait sockets.
> 
> Suggested-by: Eric Dumazet 
> Signed-off-by: Florian Westphal 

Acked-by: Hannes Frederic Sowa 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next 1/3] net: add inet_sk_transparent() helper

[Florian Westphal]

Avoids cluttering tcp_v4_send_reset when followup patch extends
it to deal with timewait sockets.

Suggested-by: Eric Dumazet 
Signed-off-by: Florian Westphal 
---
 include/net/request_sock.h |  2 +-
 include/net/tcp.h  | 12 
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/include/net/request_sock.h b/include/net/request_sock.h
index a0dde04..f49759d 100644
--- a/include/net/request_sock.h
+++ b/include/net/request_sock.h
@@ -68,7 +68,7 @@ struct request_sock {
u32 peer_secid;
 };
 
-static inline struct request_sock *inet_reqsk(struct sock *sk)
+static inline struct request_sock *inet_reqsk(const struct sock *sk)
 {
return (struct request_sock *)sk;
 }
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 3077735b..f33fecf 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1620,6 +1620,18 @@ static inline void tcp_highest_sack_combine(struct sock 
*sk,
tcp_sk(sk)->highest_sack = new;
 }
 
+/* This helper checks if socket has IP_TRANSPARENT set */
+static inline bool inet_sk_transparent(const struct sock *sk)
+{
+   switch (sk->sk_state) {
+   case TCP_TIME_WAIT:
+   return inet_twsk(sk)->tw_transparent;
+   case TCP_NEW_SYN_RECV:
+   return inet_rsk(inet_reqsk(sk))->no_srccheck;
+   }
+   return inet_sk(sk)->transparent;
+}
+
 /* Determines whether this is a thin stream (which may suffer from
  * increased latency). Used to trigger latency-reducing mechanisms.
  */
-- 
2.4.10

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html