Re: [PATCH 0/3] Action API fixes
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 6 Jul 2006 14:45:39 +0200 > * jamal <[EMAIL PROTECTED]> 2006-07-06 08:27 > > > > The proper patch is attached as a replacement for > > "[PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping action" > > from Thomas. > > If you have already submitted it, then i will send a patch against it. > > I don't understand why you're picky about this but if you really > want to then do it properly and remove the now unused err variable, > don't leave obscure code behind again. I don't either, I think Thomas's patch was correct and that's why his is the one I applied. Sometimes it is necessary for one to buffer their resistence to the way someone fixes you code and just let it go. Otherwise people won't even bother trying to fix those bugs. People who do the work make the rules, that is my supreme motto. And here that is Thomas, and therefore I will favor in the direction of his judgement. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Action API fixes
From: jamal <[EMAIL PROTECTED]> Date: Thu, 06 Jul 2006 08:03:48 -0400 > Dave, Did you actually read my comments on the patches? > One patch deserved to go to stable and one was the wrong fix. > > Should i now send a patch against the one? I read your comments. Thomas's patches were correct, you comments were refinements at best. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Action API fixes
On Thu, 2006-06-07 at 14:45 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-07-06 08:27 > > > > The proper patch is attached as a replacement for > > "[PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping action" > > from Thomas. > > If you have already submitted it, then i will send a patch against it. > > I don't understand why you're picky about this but if you really > want to then do it properly and remove the now unused err variable, > don't leave obscure code behind again. For heavens sake, do we have to argue even about this? look at the code calmly and rationally and tell me if your fix was even close to right. It was a bug. All bugs are obscure. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Action API fixes
* jamal <[EMAIL PROTECTED]> 2006-07-06 08:27 > > The proper patch is attached as a replacement for > "[PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping action" > from Thomas. > If you have already submitted it, then i will send a patch against it. I don't understand why you're picky about this but if you really want to then do it properly and remove the now unused err variable, don't leave obscure code behind again. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Action API fixes
On Thu, 2006-06-07 at 08:03 -0400, jamal wrote: > On Wed, 2006-05-07 at 20:47 -0700, David Miller wrote: > > From: Thomas Graf <[EMAIL PROTECTED]> > > Date: Wed, 05 Jul 2006 00:05:04 +0200 > > > > > Fixes for some rather serious action API bugs. Please apply. > > > > All applied, I'll push to -stable, thanks Thomas. > > Dave, Did you actually read my comments on the patches? > One patch deserved to go to stable and one was the wrong fix. > > Should i now send a patch against the one? The proper patch is attached as a replacement for "[PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping action" from Thomas. If you have already submitted it, then i will send a patch against it. cheers, jamal Fix dumping possibly returning a positive code Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- diff --git a/net/sched/act_api.c b/net/sched/act_api.c index 2ffa11c..0477c7a 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -259,7 +259,7 @@ tcf_action_dump(struct sk_buff *skb, str rtattr_failure: skb_trim(skb, b - skb->data); - return -err; + return -1; } struct tc_action *tcf_action_init_1(struct rtattr *rta, struct rtattr *est,
Re: [PATCH 0/3] Action API fixes
On Wed, 2006-05-07 at 20:47 -0700, David Miller wrote: > From: Thomas Graf <[EMAIL PROTECTED]> > Date: Wed, 05 Jul 2006 00:05:04 +0200 > > > Fixes for some rather serious action API bugs. Please apply. > > All applied, I'll push to -stable, thanks Thomas. Dave, Did you actually read my comments on the patches? One patch deserved to go to stable and one was the wrong fix. Should i now send a patch against the one? cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Action API fixes
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 05 Jul 2006 00:05:04 +0200 > Fixes for some rather serious action API bugs. Please apply. All applied, I'll push to -stable, thanks Thomas. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] Action API fixes
Dave, Fixes for some rather serious action API bugs. Please apply. net/sched/act_api.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
