Re: [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2
David S. Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 22 Apr 2006 15:22:54 +1000 Jeff Garzik [EMAIL PROTECTED] wrote: 05/10: [PATCH] Update truesize with the length of the packet for packet split These 10 patches look OK, but since the current kernel version is 2.6.17-rc1, that means we are in bug fix only mode right now. Should I (a) apply these all to netdev2-.6.git#upstream, queueing them for 2.6.18, or (b) let you split the submission into two parts, bug fixes only and everything else? It turns out that the truesize patch is pretty important as otherwise most of TCP receive socket buffer accounting falls apart. So it should probably go into 2.6.17 and even 2.6.16-stable. I totally agree. Jeff please try to get at least this skb-truesize fix queued to both -stable and current 2.6.x, it's really needed and important for proper socket memory accounting on receive with e1000. I agree, Jeff, please go ahead or let me know if you want me to submit this separately. Auke - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2
Jeff Garzik [EMAIL PROTECTED] wrote:
05/10: [PATCH] Update truesize with the length of the packet for
packet split
These 10 patches look OK, but since the current kernel version is
2.6.17-rc1, that means we are in bug fix only mode right now.
Should I (a) apply these all to netdev2-.6.git#upstream, queueing them
for 2.6.18, or (b) let you split the submission into two parts, bug
fixes only and everything else?
It turns out that the truesize patch is pretty important as otherwise
most of TCP receive socket buffer accounting falls apart. So it should
probably go into 2.6.17 and even 2.6.16-stable.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 22 Apr 2006 15:22:54 +1000 Jeff Garzik [EMAIL PROTECTED] wrote: 05/10: [PATCH] Update truesize with the length of the packet for packet split These 10 patches look OK, but since the current kernel version is 2.6.17-rc1, that means we are in bug fix only mode right now. Should I (a) apply these all to netdev2-.6.git#upstream, queueing them for 2.6.18, or (b) let you split the submission into two parts, bug fixes only and everything else? It turns out that the truesize patch is pretty important as otherwise most of TCP receive socket buffer accounting falls apart. So it should probably go into 2.6.17 and even 2.6.16-stable. I totally agree. Jeff please try to get at least this skb-truesize fix queued to both -stable and current 2.6.x, it's really needed and important for proper socket memory accounting on receive with e1000. Thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2
Hi,
This patch series implements two fixes, a series of cleanups and
two optimization patches.
The version of the driver was bumped to 7.0.38-k2. Year changes to 2006.
As I'm taking over patch duties from Jeff Kirsher, I added myself
to the MAINTAINERS file.
These changes are available through git.
Jeff, please pull from:
git://63.64.152.142/~ahkok/git/netdev-2.6 e1000-7.0.38-k2
Cheers,
Auke Kok
---
01/10: [FIX] Remove PM warning DPRINTKs breaking 2.4.x kernels
02/10: [FIX] Esb2 wol link cycle bug and uninitialized registers
03/10: [PATCH] De-inline functions to benefit from compiler smartness
04/10: [PATCH] Made an adapter struct variable into a local (txb2b)
05/10: [PATCH] Update truesize with the length of the packet for
packet split
06/10: [PATCH] Dead variable cleanup
07/10: [PATCH] Buffer optimizations for small MTU
08/10: [PATCH] implement more efficient tx queue locking
09/10: [DOC] Version bump, contact fix, year string change
10/10: [MAINTAINERS] {e100{,0},ixgb}: Add Auke Kok as new patch maintainer
for e{100,1000} and ixgb
---
MAINTAINERS |6 +
drivers/net/e1000/Makefile|1
drivers/net/e1000/e1000.h |6 -
drivers/net/e1000/e1000_ethtool.c |3
drivers/net/e1000/e1000_hw.c |3
drivers/net/e1000/e1000_hw.h |3
drivers/net/e1000/e1000_main.c| 198 ++
drivers/net/e1000/e1000_osdep.h |3
drivers/net/e1000/e1000_param.c |3
9 files changed, 118 insertions(+), 108 deletions(-)
--
Auke Kok [EMAIL PROTECTED]
Intel Pro Ethernet Driver Group
LAN Access Division / Digital Enterprise Group
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2
Kok, Auke wrote:
Hi,
This patch series implements two fixes, a series of cleanups and
two optimization patches.
The version of the driver was bumped to 7.0.38-k2. Year changes to 2006.
As I'm taking over patch duties from Jeff Kirsher, I added myself
to the MAINTAINERS file.
These changes are available through git.
Jeff, please pull from:
git://63.64.152.142/~ahkok/git/netdev-2.6 e1000-7.0.38-k2
Cheers,
Auke Kok
---
01/10: [FIX] Remove PM warning DPRINTKs breaking 2.4.x kernels
02/10: [FIX] Esb2 wol link cycle bug and uninitialized registers
03/10: [PATCH] De-inline functions to benefit from compiler smartness
04/10: [PATCH] Made an adapter struct variable into a local (txb2b)
05/10: [PATCH] Update truesize with the length of the packet for
packet split
06/10: [PATCH] Dead variable cleanup
07/10: [PATCH] Buffer optimizations for small MTU
08/10: [PATCH] implement more efficient tx queue locking
09/10: [DOC] Version bump, contact fix, year string change
10/10: [MAINTAINERS] {e100{,0},ixgb}: Add Auke Kok as new patch maintainer
These 10 patches look OK, but since the current kernel version is
2.6.17-rc1, that means we are in bug fix only mode right now.
Should I (a) apply these all to netdev2-.6.git#upstream, queueing them
for 2.6.18, or (b) let you split the submission into two parts, bug
fixes only and everything else?
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2
Jeff Garzik wrote:
Kok, Auke wrote:
01/10: [FIX] Remove PM warning DPRINTKs breaking 2.4.x kernels
02/10: [FIX] Esb2 wol link cycle bug and uninitialized registers
03/10: [PATCH] De-inline functions to benefit from compiler smartness
04/10: [PATCH] Made an adapter struct variable into a local (txb2b)
05/10: [PATCH] Update truesize with the length of the packet for
packet split
06/10: [PATCH] Dead variable cleanup
07/10: [PATCH] Buffer optimizations for small MTU
08/10: [PATCH] implement more efficient tx queue locking
09/10: [DOC] Version bump, contact fix, year string change
10/10: [MAINTAINERS] {e100{,0},ixgb}: Add Auke Kok as new patch
maintainer
These 10 patches look OK, but since the current kernel version is
2.6.17-rc1, that means we are in bug fix only mode right now.
Should I (a) apply these all to netdev2-.6.git#upstream, queueing them
for 2.6.18, or (b) let you split the submission into two parts, bug
fixes only and everything else?
jeff,
The two fixes are for low-impact bugs with workarounds, not justifying
applying them to 2.6.17-rc1 or [EMAIL PROTECTED]
Please apply to netdev-2.6.git#upstream and queue them for 2.6.18. (a).
Cheers,
Auke
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
