Re: [PATCH 1/1] make network DMA usable for non-tcp drivers

2007-06-10 Thread Dan Williams

 @@ -130,3 +130,5 @@ end:
  fault:
   return -EFAULT;
  }
 +
 +EXPORT_SYMBOL(dma_skb_copy_datagram_iovec);

We wouldn't want to merge this until code which actually uses the export is
also merged.



...and I recommend EXPORT_SYMBOL_GPL following the lead of the other
async dma options in -mm.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 1/1] make network DMA usable for non-tcp drivers

2007-06-08 Thread Ed L. Cashin
Here is a patch against the netdev-2.6 git tree that makes the net DMA
feature usable for drivers like the ATA over Ethernet block driver,
which can use dma_skb_copy_datagram_iovec when receiving data from the
network.

The change was suggested on kernelnewbies.

  http://article.gmane.org/gmane.linux.kernel.kernelnewbies/21663

Signed-off-by: Ed L. Cashin [EMAIL PROTECTED]
---
 drivers/dma/Kconfig |2 +-
 net/core/user_dma.c |2 ++
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 72be6c6..270d23e 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -14,7 +14,7 @@ config DMA_ENGINE
 comment DMA Clients
 
 config NET_DMA
-   bool Network: TCP receive copy offload
+   bool Network: receive copy offload
depends on DMA_ENGINE  NET
default y
---help---
diff --git a/net/core/user_dma.c b/net/core/user_dma.c
index 0ad1cd5..69d0b15 100644
--- a/net/core/user_dma.c
+++ b/net/core/user_dma.c
@@ -130,3 +130,5 @@ end:
 fault:
return -EFAULT;
 }
+
+EXPORT_SYMBOL(dma_skb_copy_datagram_iovec);
-- 
1.5.2.1
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/1] make network DMA usable for non-tcp drivers

2007-06-08 Thread Andrew Morton
On Fri, 8 Jun 2007 10:30:53 -0400
Ed L. Cashin [EMAIL PROTECTED] wrote:

 Here is a patch against the netdev-2.6 git tree that makes the net DMA
 feature usable for drivers like the ATA over Ethernet block driver,
 which can use dma_skb_copy_datagram_iovec when receiving data from the
 network.
 
 The change was suggested on kernelnewbies.
 
   http://article.gmane.org/gmane.linux.kernel.kernelnewbies/21663
 
 Signed-off-by: Ed L. Cashin [EMAIL PROTECTED]
 ---
  drivers/dma/Kconfig |2 +-
  net/core/user_dma.c |2 ++
  2 files changed, 3 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
 index 72be6c6..270d23e 100644
 --- a/drivers/dma/Kconfig
 +++ b/drivers/dma/Kconfig
 @@ -14,7 +14,7 @@ config DMA_ENGINE
  comment DMA Clients
  
  config NET_DMA
 - bool Network: TCP receive copy offload
 + bool Network: receive copy offload
   depends on DMA_ENGINE  NET
   default y
   ---help---
 diff --git a/net/core/user_dma.c b/net/core/user_dma.c
 index 0ad1cd5..69d0b15 100644
 --- a/net/core/user_dma.c
 +++ b/net/core/user_dma.c
 @@ -130,3 +130,5 @@ end:
  fault:
   return -EFAULT;
  }
 +
 +EXPORT_SYMBOL(dma_skb_copy_datagram_iovec);

We wouldn't want to merge this until code which actually uses the export is
also merged.

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html