Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr
On Mon, Jan 16, 2017 at 11:46:06AM -0500, David Miller wrote: > From: Shyam Saini > Date: Mon, 16 Jan 2017 14:54:35 +0530 > > > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > >> > >> Please do not ever submit two patches which have the same exact commit > >> header line, as these two patches do. > >> > >> When someone looks into the shortlog of GIT history all they will see > >> is "qed: Replace memset with eth_zero_addr" twice. > >> > >> This gives the reader no idea what might be different between those > >> two changes. > >> > >> Therefore you must give unique a commit header text for each change, > >> which communicates sufficiently what is different in each change. > > > > Thanks a lot for correcting me. I'll take care of this thing. > > > > I'm resending these two patches as > > 1). qed: Replace memset with eth_zero_addr > > 2). qed: Use eth_zero_addr > > > > I hope it resolves same commit header line conflict. > > You aren't understanding the point. > > Those two lines still say exactly the same thing. > > What is different about these two changes? The answer to that question > must propagate into those lines of text. I got your point now. As pointed by you and Mintz, I'll resend it as a single patch. I sincerely appreciate your efforts for making things clearer and correcting me. Thanks a lot, Shyam
Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr
From: "Mintz, Yuval" Date: Mon, 16 Jan 2017 17:05:05 + > Other than the fact these 2 patches change 2 different qed files, That's what I was trying to hint at, the locations within the drivers were the unique element. > is there any significant difference between what each does? > If not, why not simply do both in a single patch? Also agreed.
RE: [PATCH 1/2] qed: Replace memset with eth_zero_addr
> > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > >> > >> Please do not ever submit two patches which have the same exact > >> commit header line, as these two patches do. > >> > >> When someone looks into the shortlog of GIT history all they will see > >> is "qed: Replace memset with eth_zero_addr" twice. > >> > >> This gives the reader no idea what might be different between those > >> two changes. > >> > >> Therefore you must give unique a commit header text for each change, > >> which communicates sufficiently what is different in each change. > > > > Thanks a lot for correcting me. I'll take care of this thing. > > > > I'm resending these two patches as > > 1). qed: Replace memset with eth_zero_addr > > 2). qed: Use eth_zero_addr > > > > I hope it resolves same commit header line conflict. > > You aren't understanding the point. > > Those two lines still say exactly the same thing. > > What is different about these two changes? The answer to that question > must propagate into those lines of text. Other than the fact these 2 patches change 2 different qed files, is there any significant difference between what each does? If not, why not simply do both in a single patch?
Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr
From: Shyam Saini Date: Mon, 16 Jan 2017 14:54:35 +0530 > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: >> >> Please do not ever submit two patches which have the same exact commit >> header line, as these two patches do. >> >> When someone looks into the shortlog of GIT history all they will see >> is "qed: Replace memset with eth_zero_addr" twice. >> >> This gives the reader no idea what might be different between those >> two changes. >> >> Therefore you must give unique a commit header text for each change, >> which communicates sufficiently what is different in each change. > > Thanks a lot for correcting me. I'll take care of this thing. > > I'm resending these two patches as > 1). qed: Replace memset with eth_zero_addr > 2). qed: Use eth_zero_addr > > I hope it resolves same commit header line conflict. You aren't understanding the point. Those two lines still say exactly the same thing. What is different about these two changes? The answer to that question must propagate into those lines of text.
Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr
On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > > Please do not ever submit two patches which have the same exact commit > header line, as these two patches do. > > When someone looks into the shortlog of GIT history all they will see > is "qed: Replace memset with eth_zero_addr" twice. > > This gives the reader no idea what might be different between those > two changes. > > Therefore you must give unique a commit header text for each change, > which communicates sufficiently what is different in each change. Thanks a lot for correcting me. I'll take care of this thing. I'm resending these two patches as 1). qed: Replace memset with eth_zero_addr 2). qed: Use eth_zero_addr I hope it resolves same commit header line conflict. Regards, Shyam
Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr
Please do not ever submit two patches which have the same exact commit header line, as these two patches do. When someone looks into the shortlog of GIT history all they will see is "qed: Replace memset with eth_zero_addr" twice. This gives the reader no idea what might be different between those two changes. Therefore you must give unique a commit header text for each change, which communicates sufficiently what is different in each change.
[PATCH 1/2] qed: Replace memset with eth_zero_addr
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c b/drivers/net/ethernet/qlogic/qed/qed_l2.c index 6a3727c..778c52c 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_l2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c @@ -1776,7 +1776,7 @@ static int qed_fill_eth_dev_info(struct qed_dev *cdev, qed_fill_dev_info(cdev, &info->common); if (IS_VF(cdev)) - memset(info->common.hw_mac, 0, ETH_ALEN); + eth_zero_addr(info->common.hw_mac); return 0; } -- 2.7.4
