Re: [PATCH 1/2 v3] net: smsc911x: augment device tree bindings

[David Miller]

From: Linus Walleij 
Date: Wed,  7 Sep 2016 15:53:31 +0200

> This adds device tree bindings for:
> 
> - An optional GPIO line for releasing the RESET signal to the
>   SMSC911x devices
> 
> - An optional PME (power management event) interrupt line that
>   can be utilized to wake up the system on network activity.
>   This signal exist on all the SMSC911x devices, it is just not
>   very often routed.
> 
> Both these lines are routed to the SoC on the Qualcomm APQ8060
> Dragonboard and thus needs to be bound in the device tree.
> 
> Cc: devicet...@vger.kernel.org
> Cc: Jeremy Linton 
> Signed-off-by: Linus Walleij 

Applied.

Re: [PATCH 1/2 v3] net: smsc911x: augment device tree bindings

[Arnd Bergmann]

On Wednesday, September 7, 2016 3:53:31 PM CEST Linus Walleij wrote:
> This adds device tree bindings for:
> 
> - An optional GPIO line for releasing the RESET signal to the
>   SMSC911x devices
> 
> - An optional PME (power management event) interrupt line that
>   can be utilized to wake up the system on network activity.
>   This signal exist on all the SMSC911x devices, it is just not
>   very often routed.
> 
> Both these lines are routed to the SoC on the Qualcomm APQ8060
> Dragonboard and thus needs to be bound in the device tree.
> 
> Cc: devicet...@vger.kernel.org
> Cc: Jeremy Linton 
> Signed-off-by: Linus Walleij 
> 

Acked-by: Arnd Bergmann 

[PATCH 1/2 v3] net: smsc911x: augment device tree bindings

[Linus Walleij]

This adds device tree bindings for:

- An optional GPIO line for releasing the RESET signal to the
  SMSC911x devices

- An optional PME (power management event) interrupt line that
  can be utilized to wake up the system on network activity.
  This signal exist on all the SMSC911x devices, it is just not
  very often routed.

Both these lines are routed to the SoC on the Qualcomm APQ8060
Dragonboard and thus needs to be bound in the device tree.

Cc: devicet...@vger.kernel.org
Cc: Jeremy Linton 
Signed-off-by: Linus Walleij 
---
ChangeLog v2->v3:
- Augment interrupt specificiers to be more to the point and less
  technical as suggested by Arnd.
ChangeLog v1->v2:
- Document for "interrupts", skip mentioning "interrupts-extended"
  as both are always supported.
---
 Documentation/devicetree/bindings/net/smsc911x.txt | 15 +++
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/smsc911x.txt 
b/Documentation/devicetree/bindings/net/smsc911x.txt
index 3fed3c124411..16c3a9501f5d 100644
--- a/Documentation/devicetree/bindings/net/smsc911x.txt
+++ b/Documentation/devicetree/bindings/net/smsc911x.txt
@@ -3,9 +3,11 @@
 Required properties:
 - compatible : Should be "smsc,lan", "smsc,lan9115"
 - reg : Address and length of the io space for SMSC LAN
-- interrupts : Should contain SMSC LAN interrupt line
-- interrupt-parent : Should be the phandle for the interrupt controller
-  that services interrupts for this device
+- interrupts : one or two interrupt specifiers
+  - The first interrupt is the SMSC LAN interrupt line
+  - The second interrupt (if present) is the PME (power
+management event) interrupt that is able to wake up the host
+ system with a 50ms pulse on network activity
 - phy-mode : See ethernet.txt file in the same directory
 
 Optional properties:
@@ -21,6 +23,10 @@ Optional properties:
   external PHY
 - smsc,save-mac-address : Indicates that mac address needs to be saved
   before resetting the controller
+- reset-gpios : a GPIO line connected to the RESET (active low) signal
+  of the device. On many systems this is wired high so the device goes
+  out of reset at power-on, but if it is under program control, this
+  optional GPIO can wake up in response to it.
 
 Examples:
 
@@ -29,7 +35,8 @@ lan9220@f400 {
reg = <0xf400 0x200>;
phy-mode = "mii";
interrupt-parent = <>;
-   interrupts = <31>;
+   interrupts = <31>, <32>;
+   reset-gpios = < 30 GPIO_ACTIVE_LOW>;
reg-io-width = <4>;
smsc,irq-push-pull;
 };
-- 
2.7.4