Re: [PATCH 1/3] bonding: do not allow rlb updates to invalid mac

[David Miller]

Please resubmit this patch series with a proper cover letter.

It should have "[PATCH 0/3] ..." as the subject line and explain
at a high level what your patch series is doing, how it is doing
it, and why it is doing it that way.

You must also be explicit about which of my trees your changes
are targetting.

Thanks.

[PATCH 1/3] bonding: do not allow rlb updates to invalid mac

[Debabrata Banerjee]

Make sure multicast, broadcast, and zero mac's cannot be the output of rlb
updates, which should all be directed arps. Receive load balancing will be
collapsed if any of these happen, as the switch will broadcast.

Signed-off-by: Debabrata Banerjee 

diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index c5ac160..1b45378 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -453,7 +453,7 @@ static void rlb_update_client(struct rlb_client_info 
*client_info)
 {
int i;
 
-   if (!client_info->slave)
+   if (!client_info->slave || !is_valid_ether_addr(client_info->mac_dst))
return;
 
for (i = 0; i < RLB_ARP_BURST_SIZE; i++) {
-- 
2.8.0