Re: [PATCH 13/13] r8169: more phy init for the 8168

2007-10-24 Thread Francois Romieu 
Glen Gray <[EMAIL PROTECTED]> :
> Are any of these likely to fix the Ethernet multicast issues a few of us 
> have seen with 8110sc cards ?

No, this serie is not expected to.

I have planned to work on it again during the bugfix phase of 2.6.24-rc.

Is it still an option for you to use the old realtek driver + bandaid
(no pun) in the meantime ?

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/13] r8169: more phy init for the 8168

2007-10-24 Thread Glen Gray 
Are any of these likely to fix the Ethernet multicast issues a few of us 
have seen with 8110sc cards ?


Francois Romieu wrote:

Realtek's r8168 driver version 8.003.00 adds new init sequences
(they do not appear in version 8.002.00).

Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
Cc: Edward Hsu <[EMAIL PROTECTED]>
---
 drivers/net/r8169.c |   34 ++
 1 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 8ffd573..e8960f2 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1243,6 +1243,16 @@ static void rtl8169sb_hw_phy_config(void __iomem *ioaddr)
 
 	rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));

 }
+static void rtl8168b_hw_phy_config(void __iomem *ioaddr)
+{
+   struct phy_reg phy_reg_init[] = {
+   { 0x1f, 0x },
+   { 0x10, 0xf41b },
+   { 0x1f, 0x }
+   };
+
+   rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));
+}
 
 static void rtl8168cp_hw_phy_config(void __iomem *ioaddr)

 {
@@ -1279,6 +1289,22 @@ static void rtl8168c_hw_phy_config(void __iomem *ioaddr)
rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));
 }
 
+static void rtl8168cx_hw_phy_config(void __iomem *ioaddr)

+{
+   struct phy_reg phy_reg_init[] = {
+   { 0x1f, 0x },
+   { 0x12, 0x2300 },
+   { 0x1f, 0x0003 },
+   { 0x16, 0x0f0a },
+   { 0x1f, 0x },
+   { 0x1f, 0x0002 },
+   { 0x0c, 0x7eb8 },
+   { 0x1f, 0x }
+   };
+
+   rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));
+}
+
 static void rtl_hw_phy_config(struct net_device *dev)
 {
struct rtl8169_private *tp = netdev_priv(dev);
@@ -1296,12 +1322,20 @@ static void rtl_hw_phy_config(struct net_device *dev)
case RTL_GIGA_MAC_VER_04:
rtl8169sb_hw_phy_config(ioaddr);
break;
+   case RTL_GIGA_MAC_VER_11:
+   case RTL_GIGA_MAC_VER_12:
+   case RTL_GIGA_MAC_VER_17:
+   rtl8168b_hw_phy_config(ioaddr);
+   break;
case RTL_GIGA_MAC_VER_18:
rtl8168cp_hw_phy_config(ioaddr);
break;
case RTL_GIGA_MAC_VER_19:
rtl8168c_hw_phy_config(ioaddr);
break;
+   case RTL_GIGA_MAC_VER_20:
+   rtl8168cx_hw_phy_config(ioaddr);
+   break;
default:
break;
}
  



--
Glen Gray <[EMAIL PROTECTED]>  Digital Depot, Thomas Street
Senior Software EngineerDublin 8, Ireland
Lincor Solutions Ltd.  Ph: +353 (0) 1 4893682

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 13/13] r8169: more phy init for the 8168

2007-10-18 Thread Francois Romieu 
Realtek's r8168 driver version 8.003.00 adds new init sequences
(they do not appear in version 8.002.00).

Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
Cc: Edward Hsu <[EMAIL PROTECTED]>
---
 drivers/net/r8169.c |   34 ++
 1 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 8ffd573..e8960f2 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1243,6 +1243,16 @@ static void rtl8169sb_hw_phy_config(void __iomem *ioaddr)
 
rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));
 }
+static void rtl8168b_hw_phy_config(void __iomem *ioaddr)
+{
+   struct phy_reg phy_reg_init[] = {
+   { 0x1f, 0x },
+   { 0x10, 0xf41b },
+   { 0x1f, 0x }
+   };
+
+   rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));
+}
 
 static void rtl8168cp_hw_phy_config(void __iomem *ioaddr)
 {
@@ -1279,6 +1289,22 @@ static void rtl8168c_hw_phy_config(void __iomem *ioaddr)
rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));
 }
 
+static void rtl8168cx_hw_phy_config(void __iomem *ioaddr)
+{
+   struct phy_reg phy_reg_init[] = {
+   { 0x1f, 0x },
+   { 0x12, 0x2300 },
+   { 0x1f, 0x0003 },
+   { 0x16, 0x0f0a },
+   { 0x1f, 0x },
+   { 0x1f, 0x0002 },
+   { 0x0c, 0x7eb8 },
+   { 0x1f, 0x }
+   };
+
+   rtl_phy_write(ioaddr, phy_reg_init, ARRAY_SIZE(phy_reg_init));
+}
+
 static void rtl_hw_phy_config(struct net_device *dev)
 {
struct rtl8169_private *tp = netdev_priv(dev);
@@ -1296,12 +1322,20 @@ static void rtl_hw_phy_config(struct net_device *dev)
case RTL_GIGA_MAC_VER_04:
rtl8169sb_hw_phy_config(ioaddr);
break;
+   case RTL_GIGA_MAC_VER_11:
+   case RTL_GIGA_MAC_VER_12:
+   case RTL_GIGA_MAC_VER_17:
+   rtl8168b_hw_phy_config(ioaddr);
+   break;
case RTL_GIGA_MAC_VER_18:
rtl8168cp_hw_phy_config(ioaddr);
break;
case RTL_GIGA_MAC_VER_19:
rtl8168c_hw_phy_config(ioaddr);
break;
+   case RTL_GIGA_MAC_VER_20:
+   rtl8168cx_hw_phy_config(ioaddr);
+   break;
default:
break;
}
-- 
1.5.2.4

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html