Re: [PATCH 13/21] e1000: add E1000_BIG_ENDIAN symbol

2006-06-27 Thread Auke Kok 

Jeff Garzik wrote:

Kok, Auke wrote:

This adds a private symbol to signify endianess in our driver.

Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---

 drivers/net/e1000/e1000_hw.h|2 +-
 drivers/net/e1000/e1000_osdep.h |3 +++
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/net/e1000/e1000_hw.h b/drivers/net/e1000/e1000_hw.h
index 941b47d..376a2ef 100644
--- a/drivers/net/e1000/e1000_hw.h
+++ b/drivers/net/e1000/e1000_hw.h
@@ -351,7 +351,7 @@ struct e1000_host_mng_command_info {
 struct e1000_host_mng_command_header command_header;  /* Command 
Head/Command Result Head has 4 bytes */
 uint8_t command_data[E1000_HI_MAX_MNG_DATA_LENGTH];   /* Command 
data can length 0..0x658*/

 };
-#ifdef __BIG_ENDIAN
+#ifdef E1000_BIG_ENDIAN
 struct e1000_host_mng_dhcp_cookie{
 uint32_t signature;
 uint16_t vlan_id;
diff --git a/drivers/net/e1000/e1000_osdep.h 
b/drivers/net/e1000/e1000_osdep.h

index 048d052..6130a42 100644
--- a/drivers/net/e1000/e1000_osdep.h
+++ b/drivers/net/e1000/e1000_osdep.h
@@ -83,6 +83,9 @@ typedef enum {
 #define DEBUGOUT3 DEBUGOUT2
 #define DEBUGOUT7 DEBUGOUT3
 
+#ifdef __BIG_ENDIAN

+#define E1000_BIG_ENDIAN __BIG_ENDIAN
+#endif


NAK.  This is backwards:  We don't need wrappers for symbols that the 
kernel already provides.


Agreed, I deleted it from our git server.

Auke
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/21] e1000: add E1000_BIG_ENDIAN symbol

2006-06-26 Thread Jeff Garzik 

Kok, Auke wrote:

This adds a private symbol to signify endianess in our driver.

Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---

 drivers/net/e1000/e1000_hw.h|2 +-
 drivers/net/e1000/e1000_osdep.h |3 +++
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/net/e1000/e1000_hw.h b/drivers/net/e1000/e1000_hw.h
index 941b47d..376a2ef 100644
--- a/drivers/net/e1000/e1000_hw.h
+++ b/drivers/net/e1000/e1000_hw.h
@@ -351,7 +351,7 @@ struct e1000_host_mng_command_info {
 struct e1000_host_mng_command_header command_header;  /* Command 
Head/Command Result Head has 4 bytes */
 uint8_t command_data[E1000_HI_MAX_MNG_DATA_LENGTH];   /* Command data can 
length 0..0x658*/
 };
-#ifdef __BIG_ENDIAN
+#ifdef E1000_BIG_ENDIAN
 struct e1000_host_mng_dhcp_cookie{
 uint32_t signature;
 uint16_t vlan_id;
diff --git a/drivers/net/e1000/e1000_osdep.h b/drivers/net/e1000/e1000_osdep.h
index 048d052..6130a42 100644
--- a/drivers/net/e1000/e1000_osdep.h
+++ b/drivers/net/e1000/e1000_osdep.h
@@ -83,6 +83,9 @@ typedef enum {
 #define DEBUGOUT3 DEBUGOUT2
 #define DEBUGOUT7 DEBUGOUT3
 
+#ifdef __BIG_ENDIAN

+#define E1000_BIG_ENDIAN __BIG_ENDIAN
+#endif


NAK.  This is backwards:  We don't need wrappers for symbols that the 
kernel already provides.


Jeff


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 13/21] e1000: add E1000_BIG_ENDIAN symbol

2006-06-21 Thread Kok, Auke 

This adds a private symbol to signify endianess in our driver.

Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---

 drivers/net/e1000/e1000_hw.h|2 +-
 drivers/net/e1000/e1000_osdep.h |3 +++
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/net/e1000/e1000_hw.h b/drivers/net/e1000/e1000_hw.h
index 941b47d..376a2ef 100644
--- a/drivers/net/e1000/e1000_hw.h
+++ b/drivers/net/e1000/e1000_hw.h
@@ -351,7 +351,7 @@ struct e1000_host_mng_command_info {
 struct e1000_host_mng_command_header command_header;  /* Command 
Head/Command Result Head has 4 bytes */
 uint8_t command_data[E1000_HI_MAX_MNG_DATA_LENGTH];   /* Command data can 
length 0..0x658*/
 };
-#ifdef __BIG_ENDIAN
+#ifdef E1000_BIG_ENDIAN
 struct e1000_host_mng_dhcp_cookie{
 uint32_t signature;
 uint16_t vlan_id;
diff --git a/drivers/net/e1000/e1000_osdep.h b/drivers/net/e1000/e1000_osdep.h
index 048d052..6130a42 100644
--- a/drivers/net/e1000/e1000_osdep.h
+++ b/drivers/net/e1000/e1000_osdep.h
@@ -83,6 +83,9 @@ typedef enum {
 #define DEBUGOUT3 DEBUGOUT2
 #define DEBUGOUT7 DEBUGOUT3
 
+#ifdef __BIG_ENDIAN
+#define E1000_BIG_ENDIAN __BIG_ENDIAN
+#endif
 
 #define E1000_WRITE_REG(a, reg, value) ( \
 writel((value), ((a)-hw_addr + \



--
Auke Kok [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html