Re: [PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation

[Andrzej Hajda]

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda 
> ---
>  drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c 
> b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> index f67641a..8e23e3f 100644
> --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> @@ -602,12 +602,10 @@ int octeon_download_firmware(struct octeon_device *oct, 
> const u8 *data,
>   snprintf(oct->fw_info.liquidio_firmware_version, 32, "LIQUIDIO: %s",
>h->version);
>  
> - buffer = kmalloc(size, GFP_KERNEL);
> + buffer = kmemdup(data, size, GFP_KERNEL);
>   if (!buffer)
>   return -ENOMEM;
>  
> - memcpy(buffer, data, size);
> -
>   p = buffer + sizeof(struct octeon_firmware_file_header);
>  
>   /* load all images */

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation

[Andrzej Hajda]

The patch was generated using fixed coccinelle semantic patch
scripts/coccinelle/api/memdup.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2014320

Signed-off-by: Andrzej Hajda a.ha...@samsung.com
---
 drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c 
b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
index f67641a..8e23e3f 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
@@ -602,12 +602,10 @@ int octeon_download_firmware(struct octeon_device *oct, 
const u8 *data,
snprintf(oct-fw_info.liquidio_firmware_version, 32, LIQUIDIO: %s,
 h-version);
 
-   buffer = kmalloc(size, GFP_KERNEL);
+   buffer = kmemdup(data, size, GFP_KERNEL);
if (!buffer)
return -ENOMEM;
 
-   memcpy(buffer, data, size);
-
p = buffer + sizeof(struct octeon_firmware_file_header);
 
/* load all images */
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html