Re: [PATCH 19/21] e1000: allow user to disable ich8 lock loss workaround

2006-06-27 Thread Auke Kok

Jeff Garzik wrote:

Kok, Auke wrote:

The workaround for the ich8 lock loss problem is only needed for
a very small amount of systems. This adds an option for the user
to disable the workaround.


Does very small amount equate to never in real production machines?


Unfortunately not.


Cheers,

Auke
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 19/21] e1000: allow user to disable ich8 lock loss workaround

2006-06-26 Thread Jeff Garzik

Kok, Auke wrote:

The workaround for the ich8 lock loss problem is only needed for
a very small amount of systems. This adds an option for the user
to disable the workaround.


Does very small amount equate to never in real production machines?


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 19/21] e1000: allow user to disable ich8 lock loss workaround

2006-06-21 Thread Kok, Auke

The workaround for the ich8 lock loss problem is only needed for
a very small amount of systems. This adds an option for the user
to disable the workaround.

Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---

 drivers/net/e1000/e1000_param.c |   21 +
 1 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/drivers/net/e1000/e1000_param.c b/drivers/net/e1000/e1000_param.c
index bd6c040..0ef4131 100644
--- a/drivers/net/e1000/e1000_param.c
+++ b/drivers/net/e1000/e1000_param.c
@@ -202,6 +202,15 @@ E1000_PARAM(InterruptThrottleRate, Inte
 
 E1000_PARAM(SmartPowerDownEnable, Enable PHY smart power down);
 
+/* Enable Kumeran Lock Loss workaround
+ *
+ * Valid Range: 0, 1
+ *
+ * Default Value: 1 (enabled)
+ */
+
+E1000_PARAM(KumeranLockLoss, Enable Kumeran lock loss workaround);
+
 #define AUTONEG_ADV_DEFAULT  0x2F
 #define AUTONEG_ADV_MASK 0x2F
 #define FLOW_CONTROL_DEFAULT FLOW_CONTROL_FULL
@@ -484,6 +493,18 @@ e1000_check_options(struct e1000_adapter
e1000_validate_option(spd, opt, adapter);
adapter-smart_power_down = spd;
}
+   { /* Kumeran Lock Loss Workaround */
+   struct e1000_option opt = {
+   .type = enable_option,
+   .name = Kumeran Lock Loss Workaround,
+   .err  = defaulting to Enabled,
+   .def  = OPTION_ENABLED
+   };
+
+   int kmrn_lock_loss = KumeranLockLoss[bd];
+   e1000_validate_option(kmrn_lock_loss, opt, adapter);
+   adapter-hw.kmrn_lock_loss_workaround_disabled = 
!kmrn_lock_loss;
+   }
 
switch (adapter-hw.media_type) {
case e1000_media_type_fiber:



--
Auke Kok [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html