Re: [PATCH 2/2] [IPV4] fib_trie: fix duplicated route issue

[David Miller]

From: Joonwoo Park <[EMAIL PROTECTED]>
Date: Wed, 16 Jan 2008 20:13:49 +0900

> http://bugzilla.kernel.org/show_bug.cgi?id=9493
> 
> The fib allows making identical routes with 'ip route replace'.
> This patch makes the fib return -EEXIST if replacement would cause 
> duplication.
> 
> Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>

Also applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] [IPV4] fib_trie: fix duplicated route issue

[Joonwoo Park]

http://bugzilla.kernel.org/show_bug.cgi?id=9493

The fib allows making identical routes with 'ip route replace'.
This patch makes the fib return -EEXIST if replacement would cause duplication.

Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
 net/ipv4/fib_trie.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 8d8c291..1010b46 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -1214,6 +1214,9 @@ static int fn_trie_insert(struct fib_table *tb, struct 
fib_config *cfg)
struct fib_info *fi_drop;
u8 state;
 
+   if (fi->fib_treeref > 1)
+   goto out;
+
err = -ENOBUFS;
new_fa = kmem_cache_alloc(fn_alias_kmem, GFP_KERNEL);
if (new_fa == NULL)
-- 
1.5.3.rc5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html