Re: [PATCH 2/2] mwifiex: simplify length computation for some memset

[Julian Calaby]

Hi All,

On Mon, Aug 8, 2016 at 5:39 PM, Christophe JAILLET
 wrote:
> This patch should be a no-op. It just simplifies code by using the name of
> a variable instead of its type when calling 'sizeof'.
>
> Signed-off-by: Christophe JAILLET 

Reviewed-by: Julian Calaby 

Thanks,

-- 
Julian Calaby

Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

[PATCH 2/2] mwifiex: simplify length computation for some memset

[Christophe JAILLET]

This patch should be a no-op. It just simplifies code by using the name of
a variable instead of its type when calling 'sizeof'.

Signed-off-by: Christophe JAILLET 
---
 drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c 
b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
index 78819e8..644f3a2 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
@@ -574,7 +574,7 @@ int mwifiex_enable_hs(struct mwifiex_adapter *adapter)
 
adapter->hs_activate_wait_q_woken = false;
 
-   memset(, 0, sizeof(struct mwifiex_ds_hs_cfg));
+   memset(, 0, sizeof(hscfg));
hscfg.is_invoke_hostcmd = true;
 
adapter->hs_enabling = true;
@@ -1138,7 +1138,7 @@ int mwifiex_set_encode(struct mwifiex_private *priv, 
struct key_params *kp,
 {
struct mwifiex_ds_encrypt_key encrypt_key;
 
-   memset(_key, 0, sizeof(struct mwifiex_ds_encrypt_key));
+   memset(_key, 0, sizeof(encrypt_key));
encrypt_key.key_len = key_len;
encrypt_key.key_index = key_index;
 
-- 
2.7.4


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel 
antivirus Avast.
https://www.avast.com/antivirus