Re: [PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-10 Thread Ian McDonald 
> In that case wouldn't it be better if this user-visible structure is
> designed in a way so that it can support IPv6 later on?
> 
Yep. Feel free to submit patches!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-10 Thread Ian McDonald 
On 11/08/05, Herbert Xu <[EMAIL PROTECTED]> wrote:
> Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> >
> > -/* FIXME: this is utterly wrong */
> > +/* Structure describing an Internet (DCCP) socket address. */
> > struct sockaddr_dccp {
> > -   struct sockaddr_in  in;
> > -   unsigned intservice;
> > +   __u16   sdccp_family;   /* Address family   */
> > +   __u16   sdccp_port; /* Port number  */
> > +   __u32   sdccp_addr; /* Internet address */
> 
> Are we never going to have DCCP over IPv6?
> --
Short answer is yes we will. Long answer is that we will try and get
all the IPv4 stuff working first (still got a fair bit to do yet) and
then we will work on IPv6.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-10 Thread Herbert Xu 
On Thu, Aug 11, 2005 at 02:18:31PM +1200, Ian McDonald wrote:
> On 11/08/05, Herbert Xu <[EMAIL PROTECTED]> wrote:
> > Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> > >
> > > -/* FIXME: this is utterly wrong */
> > > +/* Structure describing an Internet (DCCP) socket address. */
> > > struct sockaddr_dccp {
> > > -   struct sockaddr_in  in;
> > > -   unsigned intservice;
> > > +   __u16   sdccp_family;   /* Address family   */
> > > +   __u16   sdccp_port; /* Port number  */
> > > +   __u32   sdccp_addr; /* Internet address */
>
> Short answer is yes we will. Long answer is that we will try and get
> all the IPv4 stuff working first (still got a fair bit to do yet) and
> then we will work on IPv6.

In that case wouldn't it be better if this user-visible structure is
designed in a way so that it can support IPv6 later on?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-10 Thread Herbert Xu 
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> 
> -/* FIXME: this is utterly wrong */
> +/* Structure describing an Internet (DCCP) socket address. */
> struct sockaddr_dccp {
> -   struct sockaddr_in  in;
> -   unsigned intservice;
> +   __u16   sdccp_family;   /* Address family   */
> +   __u16   sdccp_port; /* Port number  */
> +   __u32   sdccp_addr; /* Internet address */

Are we never going to have DCCP over IPv6?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-09 Thread Arnaldo Carvalho de Melo 
Hi David,

Please consider pulling from:

rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/

Best Regards,

- Arnaldo

tree d25c0dd1db78b1021da8902e8ef0dc37cbb5d892
parent ad7764592bf76533ffe823d7f45d7712c0bacfe2
author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1123625109 -0300
committer Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1123625109 -0300

[DCCP] Fix struct sockaddr_dccp definition

Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>

--

 dccp.h |   10 +++---
 1 files changed, 7 insertions(+), 3 deletions(-)

--

diff --git a/include/linux/dccp.h b/include/linux/dccp.h
--- a/include/linux/dccp.h
+++ b/include/linux/dccp.h
@@ -4,10 +4,14 @@
 #include 
 #include 
 
-/* FIXME: this is utterly wrong */
+/* Structure describing an Internet (DCCP) socket address. */
 struct sockaddr_dccp {
-   struct sockaddr_in  in;
-   unsigned intservice;
+   __u16   sdccp_family;   /* Address family   */
+   __u16   sdccp_port; /* Port number  */
+   __u32   sdccp_addr; /* Internet address */
+   __u32   sdccp_service;  /* Service  */
+   /* Pad to size of `struct sockaddr': 16 bytes . */
+   __u32   sdccp_pad;
 };
 
 /**
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html