Re: [PATCH 2/3] sh_eth: add missing EESIPR bits

2017-01-24 Thread Sergei Shtylyov 

On 01/23/2017 10:41 AM, Geert Uytterhoeven wrote:


Renesas SH77{34|63} manuals  describe more EESIPR bits than the current
driver. Declare the new bits with the end goal of using the bit names
instead of the bare numbers  for  the 'sh_eth_cpu_data::eesipr_value'
initializers...

Signed-off-by: Sergei Shtylyov 


Reviewed-by: Geert Uytterhoeven 


---
 drivers/net/ethernet/renesas/sh_eth.h |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

Index: net-next/drivers/net/ethernet/renesas/sh_eth.h
===
--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h
+++ net-next/drivers/net/ethernet/renesas/sh_eth.h
@@ -269,13 +269,17 @@ enum EESR_BIT {

 /* EESIPR */
 enum EESIPR_BIT {
-   EESIPR_TWBIP= 0x4000,
+   EESIPR_TWB1IP   = 0x8000,
+   EESIPR_TWBIP= 0x4000,   /* same as TWB0IP */


Ah, your adding it here ;-)


   Do you want me to add such comment in the 1st patch instead?


Gr{oetje,eeting}s,

Geert


MRB, Sergei

Re: [PATCH 2/3] sh_eth: add missing EESIPR bits

2017-01-22 Thread Geert Uytterhoeven 
On Sun, Jan 22, 2017 at 8:18 PM, Sergei Shtylyov
 wrote:
> Renesas SH77{34|63} manuals  describe more EESIPR bits than the current
> driver. Declare the new bits with the end goal of using the bit names
> instead of the bare numbers  for  the 'sh_eth_cpu_data::eesipr_value'
> initializers...
>
> Signed-off-by: Sergei Shtylyov 

Reviewed-by: Geert Uytterhoeven 

> ---
>  drivers/net/ethernet/renesas/sh_eth.h |   10 --
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> Index: net-next/drivers/net/ethernet/renesas/sh_eth.h
> ===
> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h
> +++ net-next/drivers/net/ethernet/renesas/sh_eth.h
> @@ -269,13 +269,17 @@ enum EESR_BIT {
>
>  /* EESIPR */
>  enum EESIPR_BIT {
> -   EESIPR_TWBIP= 0x4000,
> +   EESIPR_TWB1IP   = 0x8000,
> +   EESIPR_TWBIP= 0x4000,   /* same as TWB0IP */

Ah, your adding it here ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 2/3] sh_eth: add missing EESIPR bits

2017-01-22 Thread Sergei Shtylyov 
Renesas SH77{34|63} manuals  describe more EESIPR bits than the current
driver. Declare the new bits with the end goal of using the bit names
instead of the bare numbers  for  the 'sh_eth_cpu_data::eesipr_value'
initializers...

Signed-off-by: Sergei Shtylyov 

---
 drivers/net/ethernet/renesas/sh_eth.h |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

Index: net-next/drivers/net/ethernet/renesas/sh_eth.h
===
--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h
+++ net-next/drivers/net/ethernet/renesas/sh_eth.h
@@ -269,13 +269,17 @@ enum EESR_BIT {
 
 /* EESIPR */
 enum EESIPR_BIT {
-   EESIPR_TWBIP= 0x4000,
+   EESIPR_TWB1IP   = 0x8000,
+   EESIPR_TWBIP= 0x4000,   /* same as TWB0IP */
+   EESIPR_TC1IP= 0x2000,
+   EESIPR_TUCIP= 0x1000,
+   EESIPR_ROCIP= 0x0800,
EESIPR_TABTIP   = 0x0400,
EESIPR_RABTIP   = 0x0200,
EESIPR_RFCOFIP  = 0x0100,
EESIPR_ADEIP= 0x0080,
EESIPR_ECIIP= 0x0040,
-   EESIPR_FTCIP= 0x0020,
+   EESIPR_FTCIP= 0x0020,   /* same as TC0IP */
EESIPR_TDEIP= 0x0010,
EESIPR_TFUFIP   = 0x0008,
EESIPR_FRIP = 0x0004,
@@ -286,6 +290,8 @@ enum EESIPR_BIT {
EESIPR_CDIP = 0x0200,
EESIPR_TROIP= 0x0100,
EESIPR_RMAFIP   = 0x0080,
+   EESIPR_CEEFIP   = 0x0040,
+   EESIPR_CELFIP   = 0x0020,
EESIPR_RRFIP= 0x0010,
EESIPR_RTLFIP   = 0x0008,
EESIPR_RTSFIP   = 0x0004,