Re: [PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops

[Andrew Lunn]

On Wed, Aug 09, 2017 at 02:41:17PM +0200, John Crispin wrote:
> When the flow dissector first sees packets coming in on a DSA devices the
> 802.3 header wont be located where the code expects it to be as the tag
> is still present. Adding this new callback allows a DSA device to provide a
> new function that the flow_dissector can use to get the correct protocol
> and offset of the network header.
> 
> Signed-off-by: Muciri Gatimu 
> Signed-off-by: Shashidhar Lakkavalli 
> Signed-off-by: John Crispin 

Reviewed-by: Andrew Lunn 

Andrew

[PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops

[John Crispin]

When the flow dissector first sees packets coming in on a DSA devices the
802.3 header wont be located where the code expects it to be as the tag
is still present. Adding this new callback allows a DSA device to provide a
new function that the flow_dissector can use to get the correct protocol
and offset of the network header.

Signed-off-by: Muciri Gatimu 
Signed-off-by: Shashidhar Lakkavalli 
Signed-off-by: John Crispin 
---
 include/net/dsa.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/net/dsa.h b/include/net/dsa.h
index 65d7804c6f69..7f46b521313e 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -106,6 +106,8 @@ struct dsa_device_ops {
struct sk_buff *(*rcv)(struct sk_buff *skb, struct net_device *dev,
   struct packet_type *pt,
   struct net_device *orig_dev);
+   int (*flow_dissect)(const struct sk_buff *skb, __be16 *proto,
+   int *offset);
 };
 
 struct dsa_switch_tree {
-- 
2.11.0