Re: [PATCH 2/4 -rev1] Add new timeval_to_sec function

2007-07-26 Thread Eric Dumazet 

Varun Chandramohan a écrit :

A new function for converting timeval to time_t is added in time.h. Its a 
common function used in different
places. The timeout is now rounded up as per the suggestion.

Signed-off-by: Varun Chandramohan [EMAIL PROTECTED]
---
 include/linux/time.h |   11 +++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/include/linux/time.h b/include/linux/time.h
index dda9be6..908329a 100644
--- a/include/linux/time.h
+++ b/include/linux/time.h
@@ -147,6 +147,17 @@ static inline s64 timeval_to_ns(const st
 }
 
 /**

+ * timeval_to_sec - Convert timeval to seconds
+ * @tv: pointer to the timeval variable to be converted
+ *
+ * Returns the seconds representation of timeval parameter.
+ */
+static inline time_t timeval_to_sec(const struct timeval *tv)
+{
+   return (tv-tv_sec + (tv-tv_usec + 99)/100);
+}
+
+/**


return tv-tv_sec + (tv-tv_usec ? 1 : 0);

is much faster

Also, the comment is not accurate, as it doesnt mention the roundup at all.

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4 -rev1] Add new timeval_to_sec function

2007-07-26 Thread Oliver Hartkopp 
Eric Dumazet wrote:
 Varun Chandramohan a écrit :

 +return (tv-tv_sec + (tv-tv_usec + 99)/100);

 return tv-tv_sec + (tv-tv_usec ? 1 : 0);

 is much faster

It additionally wins the design award in opposite to my suggestion ;-)
Thanks!


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/4 -rev1] Add new timeval_to_sec function

2007-07-25 Thread Varun Chandramohan 
A new function for converting timeval to time_t is added in time.h. Its a 
common function used in different
places. The timeout is now rounded up as per the suggestion.

Signed-off-by: Varun Chandramohan [EMAIL PROTECTED]
---
 include/linux/time.h |   11 +++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/include/linux/time.h b/include/linux/time.h
index dda9be6..908329a 100644
--- a/include/linux/time.h
+++ b/include/linux/time.h
@@ -147,6 +147,17 @@ static inline s64 timeval_to_ns(const st
 }
 
 /**
+ * timeval_to_sec - Convert timeval to seconds
+ * @tv: pointer to the timeval variable to be converted
+ *
+ * Returns the seconds representation of timeval parameter.
+ */
+static inline time_t timeval_to_sec(const struct timeval *tv)
+{
+   return (tv-tv_sec + (tv-tv_usec + 99)/100);
+}
+
+/**
  * ns_to_timespec - Convert nanoseconds to timespec
  * @nsec:  the nanoseconds value to be converted
  *
-- 
1.4.3.4

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html