[PATCH 3/3][ATM]: potential NULL pointer dereference in clip_mkip()

2006-09-16 Thread chas williams - CONTRACTOR 
please consider for 2.6.18 -- thanks!

[ATM]: potential NULL pointer dereference in clip_mkip()

http://article.gmane.org/gmane.linux.kernel/445717

When re-processing received data, a struct sk_buff pointer skb may be
dereferenced after a free operation.

From: Frederik Deweerdt <[EMAIL PROTECTED]>
Signed-off-by: Chas Williams <[EMAIL PROTECTED]>

---
commit 87409562aeed5fb2b85dc2f9bddca0a1bbde8c37
tree 0885b8bd2b8881201de422877abd8979861c44de
parent fc6b6284e9383bd8d9fd95210fbc5e3c54ccc65d
author chas williams - CONTRACTOR <[EMAIL PROTECTED]> Sat, 16 Sep 2006 15:55:01 
-0400
committer chas williams - CONTRACTOR <[EMAIL PROTECTED]> Sat, 16 Sep 2006 
15:55:01 -0400

 net/atm/clip.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/atm/clip.c b/net/atm/clip.c
index 7ce7bfe..0dfa3a4 100644
--- a/net/atm/clip.c
+++ b/net/atm/clip.c
@@ -500,9 +500,9 @@ static int clip_mkip(struct atm_vcc *vcc
} else {
unsigned int len = skb->len;
 
-   clip_push(vcc, skb);
PRIV(skb->dev)->stats.rx_packets--;
PRIV(skb->dev)->stats.rx_bytes -= len;
+   clip_push(vcc, skb);
}
return 0;
 }
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3][ATM]: potential NULL pointer dereference in clip_mkip()

2006-09-19 Thread David Miller 
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]>
Date: Sat, 16 Sep 2006 20:19:21 -0400

> please consider for 2.6.18 -- thanks!
> 
> [ATM]: potential NULL pointer dereference in clip_mkip()
> 
> http://article.gmane.org/gmane.linux.kernel/445717
> 
> When re-processing received data, a struct sk_buff pointer skb may be
> dereferenced after a free operation.
> 
> From: Frederik Deweerdt <[EMAIL PROTECTED]>
> Signed-off-by: Chas Williams <[EMAIL PROTECTED]>

Hideaki YOSHIFUJI posted a better version of the fix which is
already in Linus's tree.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html