Re: [PATCH 3/3] [TCP]: Annotate another fackets_out state reset

2007-10-08 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Wed,  3 Oct 2007 14:00:18 +0300

 This should no longer be necessary because fackets_out is
 accurate. It indicates bugs elsewhere, thus report it.
 
 Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]

Applied, thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 3/3] [TCP]: Annotate another fackets_out state reset

2007-10-03 Thread Ilpo Järvinen
This should no longer be necessary because fackets_out is
accurate. It indicates bugs elsewhere, thus report it.

Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
 net/ipv4/tcp_input.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index e22ffe7..87c9ef5 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1160,7 +1160,8 @@ tcp_sacktag_write_queue(struct sock *sk, struct sk_buff 
*ack_skb, u32 prior_snd_
int first_sack_index;
 
if (!tp-sacked_out) {
-   tp-fackets_out = 0;
+   if (WARN_ON(tp-fackets_out))
+   tp-fackets_out = 0;
tp-highest_sack = tp-snd_una;
}
prior_fackets = tp-fackets_out;
-- 
1.5.0.6

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html