[PATCH iproute2-next] ip: don't colorize the master device

[Stephen Hemminger]

From: Stephen Hemminger 

Putting whole string "master eth0" in the interface name color
is wrong and confusing. Let's just turn color off for all attributes
of device.

Fixes: d92cc2d087b0 ("ipaddress: ll_map: Replace ll_idx_n2a() with 
ll_index_to_name()")
Signed-off-by: Stephen Hemminger 
---
 ip/ipaddress.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 1380453984d5..768e2ed27e76 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -888,11 +888,9 @@ int print_linkinfo(const struct sockaddr_nl *who,
if (tb[IFLA_MASTER]) {
int master = rta_getattr_u32(tb[IFLA_MASTER]);
 
-   print_color_string(PRINT_ANY,
-  COLOR_IFNAME,
-  "master",
-  "master %s ",
-  ll_index_to_name(master));
+   print_string(PRINT_ANY,
+"master", "master %s ",
+ll_index_to_name(master));
}
 
if (tb[IFLA_OPERSTATE])
-- 
2.16.1

Re: [PATCH iproute2-next] ip: don't colorize the master device

[David Ahern]

On 2/20/18 12:08 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger 
> 
> Putting whole string "master eth0" in the interface name color
> is wrong and confusing. Let's just turn color off for all attributes
> of device.
> 
> Fixes: d92cc2d087b0 ("ipaddress: ll_map: Replace ll_idx_n2a() with 
> ll_index_to_name()")
> Signed-off-by: Stephen Hemminger 
> ---
>  ip/ipaddress.c | 8 +++-
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 

Change in behavior too. Applied to iproute2-next