Re: [PATCH iproute2 net-next 2/3] iproute: add support for SR-IPv6 lwtunnel encapsulation

2017-04-14 Thread Stephen Hemminger
On Fri, 14 Apr 2017 14:36:22 +0200
David Lebrun  wrote:

> + if (!tb[SEG6_IPTUNNEL_SRH])
> + return

Bad indentation?


[PATCH iproute2 net-next 2/3] iproute: add support for SR-IPv6 lwtunnel encapsulation

2017-04-14 Thread David Lebrun
This patch adds support for SEG6 encapsulation type
("ip route add ... encap seg6 ...").

Signed-off-by: David Lebrun 
---
 ip/iproute.c  |   6 +-
 ip/iproute_lwtunnel.c | 154 ++
 2 files changed, 158 insertions(+), 2 deletions(-)

diff --git a/ip/iproute.c b/ip/iproute.c
index 5e23613..fef4022 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -98,8 +98,10 @@ static void usage(void)
fprintf(stderr, "TIME := NUMBER[s|ms]\n");
fprintf(stderr, "BOOL := [1|0]\n");
fprintf(stderr, "FEATURES := ecn\n");
-   fprintf(stderr, "ENCAPTYPE := [ mpls | ip | ip6 ]\n");
-   fprintf(stderr, "ENCAPHDR := [ MPLSLABEL ]\n");
+   fprintf(stderr, "ENCAPTYPE := [ mpls | ip | ip6 | seg6 ]\n");
+   fprintf(stderr, "ENCAPHDR := [ MPLSLABEL | SEG6HDR ]\n");
+   fprintf(stderr, "SEG6HDR := [ mode SEGMODE ] segs ADDR1,ADDRi,ADDRn 
[hmac HMACKEYID] [cleanup]\n");
+   fprintf(stderr, "SEGMODE := [ encap | inline ]\n");
exit(-1);
 }
 
diff --git a/ip/iproute_lwtunnel.c b/ip/iproute_lwtunnel.c
index 0fa1cab..85f586a 100644
--- a/ip/iproute_lwtunnel.c
+++ b/ip/iproute_lwtunnel.c
@@ -19,6 +19,13 @@
 #include 
 #include 
 #include 
+
+#ifndef __USE_KERNEL_IPV6_DEFS
+#define __USE_KERNEL_IPV6_DEFS
+#endif
+#include 
+#include 
+#include 
 #include 
 
 #include "rt_names.h"
@@ -39,6 +46,8 @@ static const char *format_encap_type(int type)
return "ila";
case LWTUNNEL_ENCAP_BPF:
return "bpf";
+   case LWTUNNEL_ENCAP_SEG6:
+   return "seg6";
default:
return "unknown";
}
@@ -69,12 +78,49 @@ static int read_encap_type(const char *name)
return LWTUNNEL_ENCAP_ILA;
else if (strcmp(name, "bpf") == 0)
return LWTUNNEL_ENCAP_BPF;
+   else if (strcmp(name, "seg6") == 0)
+   return LWTUNNEL_ENCAP_SEG6;
else if (strcmp(name, "help") == 0)
encap_type_usage();
 
return LWTUNNEL_ENCAP_NONE;
 }
 
+static void print_encap_seg6(FILE *fp, struct rtattr *encap)
+{
+   struct rtattr *tb[SEG6_IPTUNNEL_MAX+1];
+   struct seg6_iptunnel_encap *tuninfo;
+   struct ipv6_sr_hdr *srh;
+   int i;
+
+   parse_rtattr_nested(tb, SEG6_IPTUNNEL_MAX, encap);
+
+   if (!tb[SEG6_IPTUNNEL_SRH])
+   return;
+
+   tuninfo = RTA_DATA(tb[SEG6_IPTUNNEL_SRH]);
+   fprintf(fp, "mode %s ",
+   (tuninfo->mode == SEG6_IPTUN_MODE_ENCAP) ? "encap" : "inline");
+
+   srh = tuninfo->srh;
+
+   fprintf(fp, "segs %d [ ", srh->first_segment + 1);
+
+   for (i = srh->first_segment; i >= 0; i--)
+   fprintf(fp, "%s ",
+   rt_addr_n2a(AF_INET6, 16, &srh->segments[i]));
+
+   fprintf(fp, "] ");
+
+   if (sr_has_hmac(srh)) {
+   unsigned int offset = ((srh->hdrlen + 1) << 3) - 40;
+   struct sr6_tlv_hmac *tlv;
+
+   tlv = (struct sr6_tlv_hmac *)((char *)srh + offset);
+   fprintf(fp, "hmac 0x%X ", ntohl(tlv->hmackeyid));
+   }
+}
+
 static void print_encap_mpls(FILE *fp, struct rtattr *encap)
 {
struct rtattr *tb[MPLS_IPTUNNEL_MAX+1];
@@ -238,9 +284,114 @@ void lwt_print_encap(FILE *fp, struct rtattr *encap_type,
case LWTUNNEL_ENCAP_BPF:
print_encap_bpf(fp, encap);
break;
+   case LWTUNNEL_ENCAP_SEG6:
+   print_encap_seg6(fp, encap);
+   break;
}
 }
 
+static int parse_encap_seg6(struct rtattr *rta, size_t len, int *argcp,
+   char ***argvp)
+{
+   int mode_ok = 0, segs_ok = 0, hmac_ok = 0;
+   struct seg6_iptunnel_encap *tuninfo;
+   struct ipv6_sr_hdr *srh;
+   char **argv = *argvp;
+   char segbuf[1024];
+   int argc = *argcp;
+   int encap = -1;
+   __u32 hmac = 0;
+   int nsegs = 0;
+   int srhlen;
+   char *s;
+   int i;
+
+   while (argc > 0) {
+   if (strcmp(*argv, "mode") == 0) {
+   NEXT_ARG();
+   if (mode_ok++)
+   duparg2("mode", *argv);
+   if (strcmp(*argv, "encap") == 0)
+   encap = 1;
+   else if (strcmp(*argv, "inline") == 0)
+   encap = 0;
+   else
+   invarg("\"mode\" value is invalid\n", *argv);
+   } else if (strcmp(*argv, "segs") == 0) {
+   NEXT_ARG();
+   if (segs_ok++)
+   duparg2("segs", *argv);
+   if (encap == -1)
+   invarg("\"segs\" provided before \"mode\"\n",
+  *argv);
+
+   strncpy(segbuf, *argv, 1024);
+   segbuf[1023] = 0;
+   } else if (strcmp(*argv,