Re: [PATCH net] net: mvpp2: Fix parser entry init boundary check

[David Miller]

From: Maxime Chevallier 
Date: Thu,  5 Apr 2018 11:55:48 +0200

> Boundary check in mvpp2_prs_init_from_hw must be done according to the
> passed "tid" parameter, not the mvpp2_prs_entry index, which is not yet
> initialized at the time of the check.
> 
> Fixes: 47e0e14eb1a6 ("net: mvpp2: Make mvpp2_prs_hw_read a parser entry init 
> function")
> Signed-off-by: Maxime Chevallier 

Applied, thanks.

[PATCH net] net: mvpp2: Fix parser entry init boundary check

[Maxime Chevallier]

Boundary check in mvpp2_prs_init_from_hw must be done according to the
passed "tid" parameter, not the mvpp2_prs_entry index, which is not yet
initialized at the time of the check.

Fixes: 47e0e14eb1a6 ("net: mvpp2: Make mvpp2_prs_hw_read a parser entry init 
function")
Signed-off-by: Maxime Chevallier 
---
 drivers/net/ethernet/marvell/mvpp2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2.c 
b/drivers/net/ethernet/marvell/mvpp2.c
index 7fc1bbf51c44..54a038943c06 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -1604,7 +1604,7 @@ static int mvpp2_prs_init_from_hw(struct mvpp2 *priv,
 {
int i;
 
-   if (pe->index > MVPP2_PRS_TCAM_SRAM_SIZE - 1)
+   if (tid > MVPP2_PRS_TCAM_SRAM_SIZE - 1)
return -EINVAL;
 
memset(pe, 0, sizeof(*pe));
-- 
2.11.0