Re: [PATCH net-next] liquidio: get rid of false alarm "Unknown cmd 27" in dmesg

2017-10-28 Thread David Miller
From: Felix Manlunas 
Date: Fri, 27 Oct 2017 14:37:03 -0700

> Creating a macvtap interface with the liquidio VF driver as lower device
> causes this alarming message to show up in dmesg:
> 
> liquidio_link_ctrl_cmd_completion Unknown cmd 27
> 
> That's actually a false alarm because cmd 27 is the value of the macro
> OCTNET_CMD_SET_UC_LIST which is known.  It's a control command sent from
> host to NIC firmware to set the unicast MAC address list of the macvtap
> lower device.
> 
> Make the false alarm go away by adding a case for OCTNET_CMD_SET_UC_LIST
> in liquidio_link_ctrl_cmd_completion().
> 
> Signed-off-by: Felix Manlunas 
> Signed-off-by: Raghu Vatsavayi 

Applied.


[PATCH net-next] liquidio: get rid of false alarm "Unknown cmd 27" in dmesg

2017-10-27 Thread Felix Manlunas
Creating a macvtap interface with the liquidio VF driver as lower device
causes this alarming message to show up in dmesg:

liquidio_link_ctrl_cmd_completion Unknown cmd 27

That's actually a false alarm because cmd 27 is the value of the macro
OCTNET_CMD_SET_UC_LIST which is known.  It's a control command sent from
host to NIC firmware to set the unicast MAC address list of the macvtap
lower device.

Make the false alarm go away by adding a case for OCTNET_CMD_SET_UC_LIST
in liquidio_link_ctrl_cmd_completion().

Signed-off-by: Felix Manlunas 
Signed-off-by: Raghu Vatsavayi 
---
 drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c 
b/drivers/net/ethernet/cavium/liquidio/lio_core.c
index b891d85..89b7820 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
@@ -143,6 +143,7 @@ void liquidio_link_ctrl_cmd_completion(void *nctrl_ptr)
switch (nctrl->ncmd.s.cmd) {
case OCTNET_CMD_CHANGE_DEVFLAGS:
case OCTNET_CMD_SET_MULTI_LIST:
+   case OCTNET_CMD_SET_UC_LIST:
break;
 
case OCTNET_CMD_CHANGE_MACADDR: