Re: [PATCH net-next] net/mlx4_en: Hardware accelerated 802.1ad works only on the first port

2015-07-29 Thread David Miller
From: Amir Vadai 
Date: Tue, 28 Jul 2015 13:19:19 +0300

> Fix mistakenly used, hard coded, port number in get_phv_bit()
> 
> Fixes: 77fc29c ("net/mlx4_core: Preparations for 802.1ad VLAN support")
> Signed-off-by: Amir Vadai 

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH net-next] net/mlx4_en: Hardware accelerated 802.1ad works only on the first port

2015-07-28 Thread Amir Vadai
Fix mistakenly used, hard coded, port number in get_phv_bit()

Fixes: 77fc29c ("net/mlx4_core: Preparations for 802.1ad VLAN support")
Signed-off-by: Amir Vadai 
---
Hi Dave,

Because of my mistake I've sent a version [1] without some internal review
fixes.  This patch fix the only code issue that was missing. The rest were only
improvements to the commit messages, which unfortunately it is too late to fix 
now.

[1] - http://www.spinics.net/lists/netdev/msg337148.html

Thanks,
Amir


 drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c 
b/drivers/net/ethernet/mellanox/mlx4/fw.c
index 5a1c3d2..e8ec1de 100644
--- a/drivers/net/ethernet/mellanox/mlx4/fw.c
+++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
@@ -2815,7 +2815,7 @@ int get_phv_bit(struct mlx4_dev *dev, u8 port, int *phv)
struct mlx4_func_cap func_cap;
 
memset(&func_cap, 0, sizeof(func_cap));
-   err = mlx4_QUERY_FUNC_CAP(dev, 1, &func_cap);
+   err = mlx4_QUERY_FUNC_CAP(dev, port, &func_cap);
if (!err)
*phv = func_cap.flags & QUERY_FUNC_CAP_PHV_BIT;
return err;
-- 
2.4.3.413.ga5fe668

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html