Re: [PATCH net-next] nfp: inform the VF driver needs to be restarted after changing the MAC

2017-10-28 Thread David Miller
From: Jakub Kicinski 
Date: Thu, 26 Oct 2017 17:35:38 -0700

> From: Pablo Cascón 
> 
> Add message to inform the VF MAC was changed and the need to restart
> the VF driver for the changes to be effective.
> 
> Signed-off-by: Pablo Cascón 
> Signed-off-by: Jakub Kicinski 

Applied, thanks!


[PATCH net-next] nfp: inform the VF driver needs to be restarted after changing the MAC

2017-10-26 Thread Jakub Kicinski
From: Pablo Cascón 

Add message to inform the VF MAC was changed and the need to restart
the VF driver for the changes to be effective.

Signed-off-by: Pablo Cascón 
Signed-off-by: Jakub Kicinski 
---
 drivers/net/ethernet/netronome/nfp/nfp_net_sriov.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_sriov.c 
b/drivers/net/ethernet/netronome/nfp/nfp_net_sriov.c
index e6d2e06b050c..8b1b962cf1d1 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_sriov.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_sriov.c
@@ -112,7 +112,13 @@ int nfp_app_set_vf_mac(struct net_device *netdev, int vf, 
u8 *mac)
writew(get_unaligned_be16(mac + 4),
   app->pf->vfcfg_tbl2 + vf_offset + NFP_NET_VF_CFG_MAC_LO);
 
-   return nfp_net_sriov_update(app, vf, NFP_NET_VF_CFG_MB_UPD_MAC, "MAC");
+   err = nfp_net_sriov_update(app, vf, NFP_NET_VF_CFG_MB_UPD_MAC, "MAC");
+   if (!err)
+   nfp_info(app->pf->cpp,
+"MAC %pM set on VF %d, reload the VF driver to make 
this change effective.\n",
+mac, vf);
+
+   return err;
 }
 
 int nfp_app_set_vf_vlan(struct net_device *netdev, int vf, u16 vlan, u8 qos,
-- 
2.14.1