[PATCH net-next] ravb: Add ESF in RCR for enabling separation filter
From: Masaru Nagai This patch adds enabling separation filter(ESF) is setting value of B'11. This setting filter for separating AVB stream frames from non-AVB stream frames is enabled. Non-matching frames from a stream are processed in queue 0(best effort). H/W manual recommends B'11 or B'10. When B'10 is setting, Non-mating frames are discarded. Signed-off-by: Masaru Nagai Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's next networking tree. drivers/net/ethernet/renesas/ravb_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 867caf6..1ceadbf 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -402,7 +402,8 @@ static int ravb_dmac_init(struct net_device *ndev) #endif /* Set AVB RX */ - ravb_write(ndev, RCR_EFFS | RCR_ENCF | RCR_ETS0 | 0x1800, RCR); + ravb_write(ndev, + RCR_EFFS | RCR_ENCF | RCR_ETS0 | RCR_ESF | 0x1800, RCR); /* Set FIFO size */ ravb_write(ndev, TGC_TQP_AVBMODE1 | 0x0000, TGC); -- 1.9.1
Re: [PATCH net-next] ravb: Add ESF in RCR for enabling separation filter
On 05/29/2016 11:25 PM, Yoshihiro Kaneko wrote: From: Masaru Nagai This patch adds enabling separation filter(ESF) is setting value of B'11. This setting filter for separating AVB stream frames from non-AVB stream frames is enabled. Non-matching frames from a stream are processed in queue 0(best effort). H/W manual recommends B'11 or B'10. When B'10 is setting, Non-mating frames are discarded. It was somewhat hard for me to parse that... Signed-off-by: Masaru Nagai Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko Acked-by: Sergei Shtylyov MBR, Sergei
Re: [PATCH net-next] ravb: Add ESF in RCR for enabling separation filter
On 05/30/2016 05:30 PM, Sergei Shtylyov wrote: From: Masaru Nagai This patch adds enabling separation filter(ESF) is setting value of B'11. This setting filter for separating AVB stream frames from non-AVB stream frames is enabled. Non-matching frames from a stream are processed in queue 0(best effort). H/W manual recommends B'11 or B'10. When B'10 is setting, Non-mating frames are discarded. It was somewhat hard for me to parse that... Forgot about s/Non-mating/Non-matching/. Signed-off-by: Masaru Nagai Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko Acked-by: Sergei Shtylyov MBR, Sergei
Re: [PATCH net-next] ravb: Add ESF in RCR for enabling separation filter
Hi Sergei, 2016-05-31 6:19 GMT+09:00 Sergei Shtylyov : > On 05/30/2016 05:30 PM, Sergei Shtylyov wrote: > >>> From: Masaru Nagai >>> >>> This patch adds enabling separation filter(ESF) is setting value of B'11. >>> This setting filter for separating AVB stream frames from non-AVB stream >>> frames is enabled. Non-matching frames from a stream are processed in >>> queue 0(best effort). H/W manual recommends B'11 or B'10. >>> When B'10 is setting, Non-mating frames are discarded. >> >> >>It was somewhat hard for me to parse that... > > >Forgot about s/Non-mating/Non-matching/. Thanks for your review. I will revise the commit message. Thanks, kaneko > > >>> Signed-off-by: Masaru Nagai >>> Signed-off-by: Kazuya Mizuguchi >>> Signed-off-by: Yoshihiro Kaneko >> >> >> Acked-by: Sergei Shtylyov > > > MBR, Sergei >