Re: [PATCH net-next] ravb: use pdev rather than ndev for error messages

[David Miller]

From: Simon Horman 
Date: Mon,  2 Nov 2015 10:40:17 +0900

> This corrects what appear to be typos, making the code consistent with
> itself, and allowing meaningful prefixes to be displayed with the errors in
> question.
> 
> Before:
>  (null): failed to initialize MDIO
>  (null): Cannot allocate desc base address table (size 176 bytes)
> 
> After:
> ravb e680.ethernet: failed to initialize MDIO
> ravb e680.ethernet: Cannot allocate desc base address table (size 176 
> bytes)
> 
> Signed-off-by: Simon Horman 

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH net-next] ravb: use pdev rather than ndev for error messages

[Simon Horman]

This corrects what appear to be typos, making the code consistent with
itself, and allowing meaningful prefixes to be displayed with the errors in
question.

Before:
 (null): failed to initialize MDIO
 (null): Cannot allocate desc base address table (size 176 bytes)

After:
ravb e680.ethernet: failed to initialize MDIO
ravb e680.ethernet: Cannot allocate desc base address table (size 176 bytes)

Signed-off-by: Simon Horman 

---

Tested using an r8a7795/Salvatore-X on the topic/gen3-latest branch of
Geert Uytterhoeven's renesas-drivers tree on kernel.org: 3f5a88be9fea
("[WIP] arm64: renesas: r8a7795: Convert to new CPG/MSSR bindings")
---
 drivers/net/ethernet/renesas/ravb_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
b/drivers/net/ethernet/renesas/ravb_main.c
index af52c88b8b8f..2f345da1cc66 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1798,7 +1798,7 @@ static int ravb_probe(struct platform_device *pdev)
priv->desc_bat = dma_alloc_coherent(ndev->dev.parent, 
priv->desc_bat_size,
>desc_bat_dma, GFP_KERNEL);
if (!priv->desc_bat) {
-   dev_err(>dev,
+   dev_err(>dev,
"Cannot allocate desc base address table (size %d 
bytes)\n",
priv->desc_bat_size);
error = -ENOMEM;
@@ -1825,7 +1825,7 @@ static int ravb_probe(struct platform_device *pdev)
/* MDIO bus init */
error = ravb_mdio_init(priv);
if (error) {
-   dev_err(>dev, "failed to initialize MDIO\n");
+   dev_err(>dev, "failed to initialize MDIO\n");
goto out_dma_free;
}
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html