Re: [PATCH net-next] selftests/net: Fix broken test case in psock_fanout

2017-04-25 Thread David Miller
From: Mike Maloney 
Date: Mon, 24 Apr 2017 21:29:11 -0400

> From: Mike Maloney 
> 
> The error return falue form sock_fanout_open is -1, not zero.  One test
> case was checking for 0 instead of -1.
> 
> Tested: Built and tested in clean client.
> Signed-off-by: Mike Maloney 

Applied, thanks.


[PATCH net-next] selftests/net: Fix broken test case in psock_fanout

2017-04-24 Thread Mike Maloney
From: Mike Maloney 

The error return falue form sock_fanout_open is -1, not zero.  One test
case was checking for 0 instead of -1.

Tested: Built and tested in clean client.
Signed-off-by: Mike Maloney 
---
 tools/testing/selftests/net/psock_fanout.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/psock_fanout.c 
b/tools/testing/selftests/net/psock_fanout.c
index b4b1d91fcea5..989f917068d1 100644
--- a/tools/testing/selftests/net/psock_fanout.c
+++ b/tools/testing/selftests/net/psock_fanout.c
@@ -305,7 +305,7 @@ static void test_unique_fanout_group_ids(void)
exit(1);
}
 
-   if (sock_fanout_open(PACKET_FANOUT_CPU, first_group_id)) {
+   if (sock_fanout_open(PACKET_FANOUT_CPU, first_group_id) != -1) {
fprintf(stderr, "ERROR: joined group with wrong type.\n");
exit(1);
}
-- 
2.13.0.rc0.306.g87b477812d-goog